EBML: Fix warnings

Serial-ATA · Jul 4, 2023 · f1cc653 · f1cc653
1 parent f7f8153
commit f1cc653
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/src/ebml/mod.rs b/src/ebml/mod.rs
@@ -13,9 +13,10 @@ pub use tag::EbmlTag;
 /// An EBML file
 #[derive(LoftyFile, Default)]
 #[lofty(read_fn = "read::read_from")]
+// TODO: #[lofty(internal_write_module_do_not_use_anywhere_else)]
 pub struct EbmlFile {
-	/// An ID3v2 tag
-	#[lofty(tag_type = "Id3v2")]
+	/// An EBML tag
+	#[lofty(tag_type = "Ebml")]
 	pub(crate) ebml_tag: Option<EbmlTag>,
 	/// The file's audio properties
 	pub(crate) properties: EbmlProperties,

diff --git a/src/ebml/properties.rs b/src/ebml/properties.rs
@@ -5,7 +5,7 @@ use crate::properties::FileProperties;
 pub struct EbmlProperties {}
 
 impl From<EbmlProperties> for FileProperties {
-	fn from(input: EbmlProperties) -> Self {
+	fn from(_input: EbmlProperties) -> Self {
 		todo!()
 	}
 }
diff --git a/src/ebml/read.rs b/src/ebml/read.rs
@@ -4,7 +4,7 @@ use crate::probe::ParseOptions;
 
 use std::io::{Read, Seek};
 
-pub(super) fn read_from<R>(reader: &mut R, parse_options: ParseOptions) -> Result<EbmlFile>
+pub(super) fn read_from<R>(_reader: &mut R, _parse_options: ParseOptions) -> Result<EbmlFile>
 where
 	R: Read + Seek,
 {

diff --git a/src/ebml/tag/mod.rs b/src/ebml/tag/mod.rs
@@ -24,27 +24,27 @@ impl TagExt for EbmlTag {
 		todo!()
 	}
 
-	fn contains<'a>(&'a self, key: Self::RefKey<'a>) -> bool {
+	fn contains<'a>(&'a self, _key: Self::RefKey<'a>) -> bool {
 		todo!()
 	}
 
 	fn is_empty(&self) -> bool {
 		todo!()
 	}
 
-	fn save_to(&self, file: &mut File) -> std::result::Result<(), Self::Err> {
+	fn save_to(&self, _file: &mut File) -> std::result::Result<(), Self::Err> {
 		todo!()
 	}
 
-	fn dump_to<W: Write>(&self, writer: &mut W) -> std::result::Result<(), Self::Err> {
+	fn dump_to<W: Write>(&self, _writer: &mut W) -> std::result::Result<(), Self::Err> {
 		todo!()
 	}
 
-	fn remove_from_path<P: AsRef<Path>>(&self, path: P) -> std::result::Result<(), Self::Err> {
+	fn remove_from_path<P: AsRef<Path>>(&self, _path: P) -> std::result::Result<(), Self::Err> {
 		todo!()
 	}
 
-	fn remove_from(&self, file: &mut File) -> std::result::Result<(), Self::Err> {
+	fn remove_from(&self, _file: &mut File) -> std::result::Result<(), Self::Err> {
 		todo!()
 	}
 
@@ -81,7 +81,7 @@ impl SplitTag for EbmlTag {
 impl MergeTag for SplitTagRemainder {
 	type Merged = EbmlTag;
 
-	fn merge_tag(self, tag: Tag) -> Self::Merged {
+	fn merge_tag(self, _tag: Tag) -> Self::Merged {
 		todo!()
 	}
 }