Tests: Ignore more TagLib tests with unimplemented features

Serial-ATA · Dec 3, 2023 · 1bd7217 · 1bd7217
1 parent 5a9d7be
commit 1bd7217
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 23 deletions.
diff --git a/tests/taglib/test_ogaflac.rs b/tests/taglib/test_ogaflac.rs
@@ -6,30 +6,31 @@ use lofty::flac::FlacFile;
 use lofty::ogg::VorbisComments;
 use lofty::{Accessor, AudioFile, ParseOptions};
 
+// TODO: We don't support FLAC in OGA (#172)
 #[test]
+#[ignore]
 fn test_framing_bit() {
-	todo!("We don't support FLAC in OGA")
-	// let mut file = temp_file!("tests/taglib/data/empty_flac.oga");
-	//
-	// {
-	// 	let mut f = FlacFile::read_from(&mut file, ParseOptions::new()).unwrap();
-	// 	file.rewind().unwrap();
-	//
-	// 	let mut vorbis_comments = VorbisComments::new();
-	// 	vorbis_comments.set_artist(String::from("The Artist"));
-	// 	f.set_vorbis_comments(vorbis_comments);
-	// 	f.save_to(&mut file).unwrap();
-	// }
-	// file.rewind().unwrap();
-	// {
-	// 	let f = FlacFile::read_from(&mut file, ParseOptions::new()).unwrap();
-	// 	assert_eq!(
-	// 		f.vorbis_comments().unwrap().artist().as_deref(),
-	// 		Some("The Artist")
-	// 	);
-	//
-	// 	assert_eq!(file.seek(SeekFrom::End(0)).unwrap(), 9134);
-	// }
+	let mut file = temp_file!("tests/taglib/data/empty_flac.oga");
+
+	{
+		let mut f = FlacFile::read_from(&mut file, ParseOptions::new()).unwrap();
+		file.rewind().unwrap();
+
+		let mut vorbis_comments = VorbisComments::new();
+		vorbis_comments.set_artist(String::from("The Artist"));
+		f.set_vorbis_comments(vorbis_comments);
+		f.save_to(&mut file).unwrap();
+	}
+	file.rewind().unwrap();
+	{
+		let f = FlacFile::read_from(&mut file, ParseOptions::new()).unwrap();
+		assert_eq!(
+			f.vorbis_comments().unwrap().artist().as_deref(),
+			Some("The Artist")
+		);
+
+		assert_eq!(file.seek(SeekFrom::End(0)).unwrap(), 9134);
+	}
 }
 
 // TODO: We don't support FLAC in OGA (#172)

diff --git a/tests/taglib/test_ogg.rs b/tests/taglib/test_ogg.rs
@@ -89,6 +89,7 @@ fn test_audio_properties() {
 
 // TODO: Need to look into this one, not sure why there's a difference in checksums
 #[test]
+#[ignore]
 fn test_page_checksum() {
 	let mut file = temp_file!("tests/taglib/data/empty.ogg");
 

diff --git a/tests/taglib/test_wav.rs b/tests/taglib/test_wav.rs
@@ -105,9 +105,10 @@ fn test_id3v2_tag() {
 	}
 }
 
+// TODO: Support downgrading to ID3v2.3 (#62)
 #[test]
+#[ignore]
 fn test_save_id3v23() {
-	todo!("Support writing ID3v2.3")
 	// let mut file = temp_file!("tests/taglib/data/empty.wav");
 	//
 	// let xxx = "X".repeat(254);