Cherry-pick 7 ladybird PRs #25372
Merged
Cherry-pick 7 ladybird PRs #25372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2c8fb4957871bca5694fc9e9f8932c9769967bd1)
Previously, the value sanitization algorithm would not trim whitespace for inputs of type URL or email, if they didn't also contain any newlines. (cherry picked from commit c4b82318f41ecc0a3e24fe5c8ca0a3f02816c3b1)
(cherry picked from commit eb4e40bc49d2ad78335d0e95482a9c702764a8c9)
(cherry picked from commit 2d7547921b98747153ae9d9dda3d5479d4e9036f)
This change ensures that the value sanitization algorithm is run and the text cursor is set to the correct position when the type attribute of an input is changed. (cherry picked from commit 1b74104c17726018788034f2ad66201889ce6225)
github-actions
bot
added
the
👀 pr-needs-review
This was added in 9d03ea6 for LibWeb/DumpLayoutTree/main.cpp. That utility was moved to LibViewView in SerenityOS#14018 and then deleted in SerenityOS#18879 after SerenityOS#17836 moved that functionality to headless-browser. No behavior change.
(cherry picked from commit b688bbf26c6efb84fec19ec900cd3f1a4cf04a1b)
The IPCs to request a page's text, layout tree, etc. are currently all synchronous. This can result in a deadlock when WebContent also makes a synchronous IPC call, as both ends will be waiting on each other. This replaces the page info IPCs with a single, asynchronous IPC. This new IPC is promise-based, much like our screenshot IPC. (cherry picked from commit 3332230cef8091f94f5c30e1f1984c1038cd4a1d)
This corresponds to a recent change in the spec: w3c/webcrypto#372 Inspired by the following review comment: LadybirdBrowser/ladybird#1877 (comment) (cherry picked from commit ee3b86c3f87d8a44ba92c8aaff75925948ceacfd)
This corresponds to a recent change in the spec: w3c/webcrypto#379 (cherry picked from commit efad0b56769957e81e2420e4ccaef212baf5ea9f)
(cherry picked from commit 85356094b50878e78d40d79c2a9e96ff9aac5a6b)
(cherry picked from commit f80fca2deeb2b0ea5ffd0af714bcd79b3ad729dd)
Corresponds to whatwg/html#10091 (cherry picked from commit 36f8dfaed02a967de620a7e2abc8bd254cd7f9a5)
nico
force-pushed
the
bulk_sync_1731415186
branch
from
207b34d
to
f6593ea
Compare
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LadybirdBrowser/ladybird#1337
LadybirdBrowser/ladybird#1360
LadybirdBrowser/ladybird#1447
LadybirdBrowser/ladybird#1970
LadybirdBrowser/ladybird#1934
LadybirdBrowser/ladybird#2084
LadybirdBrowser/ladybird#2223
Also remove unused
OutOfProcessWebView::dump_layout_treeto make LadybirdBrowser/ladybird#1447 actually build.