-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF Resume Upload, Fill out education information, Incognito Mode #48
Open
tommmmyb
wants to merge
18
commits into
SeanDaBlack:main
Choose a base branch
from
tommmmyb:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e354d87
pdf upload and education info
tommmmyb 948d3aa
remove pdf2image
tommmmyb 6ed731b
clean up
tommmmyb 93cc30a
added entry fields
tommmmyb 85996be
oops
tommmmyb 864465e
changed salary range input
tommmmyb 8396d34
Merge branch 'SeanDaBlack:main' into main
tommmmyb e26e246
Merge remote-tracking branch 'SeanDaBlack/latex_resumes'
tommmmyb 91d338c
readme update
tommmmyb 1132e92
Merge branch 'main' into main
ff4949b
Removed testing code
KathrynElrod 485c70b
updated developercv
KathrynElrod 1cae473
Cross-platform friendly pathnames
tommmmyb a53e7e9
Merge remote-tracking branch 'SeanDaBlack/main'
tommmmyb 3bcabd1
added rest of education options
tommmmyb 8d41c59
Merge remote-tracking branch 'SeanDaBlack/more_templates'
tommmmyb feb7f90
fixed bad characters
tommmmyb e2b3a3b
unfilled entry fixes
tommmmyb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,65 @@ | ||
YES = 'Yes' | ||
NO = 'No' | ||
GENDERS_LIST = ['Male', 'Female', 'Other'] | ||
|
||
|
||
|
||
REFERRAL_LIST = [ | ||
'Career Event', | ||
'Company Website', | ||
'Employee Referral', | ||
'Job Board', | ||
'Print Advertisement', | ||
'Recruiter ', | ||
'Search Engine (Google, Bing, etc.)', | ||
'Social Media', | ||
'University Recruiting' | ||
] | ||
|
||
ETHNICITY_LIST = [ | ||
'American Indian/Alaskan Native', | ||
'Asian', | ||
'Black or African American', | ||
'Hispanic or Latino', | ||
'Native Hawaiian or Other Pacific Island', | ||
'Two or More Races', | ||
'Undeclared', | ||
'White' | ||
] | ||
|
||
DISABILITY_LIST = [ | ||
'No disability', | ||
'Not willing to answer', | ||
'Yes, with a disability (or previously had a disability)' | ||
] | ||
|
||
# Incomplete List | ||
INDUSTRY_LIST = [ | ||
'Construction/Mining', | ||
'Custom Services', | ||
'Distribution Service', | ||
'Finance Services', | ||
'Food Industry', | ||
'Goods Transportation', | ||
'Government', | ||
'Health Care', | ||
'Human Resources', | ||
'Information Technology Services' | ||
] | ||
|
||
# Incomplete List | ||
GRADUATION_STATUS = [ | ||
'Graduated - Degree Received', | ||
'Completed - Non Degree Program' | ||
] | ||
|
||
# Incomplete List | ||
DEGREE_MAJORS = [ | ||
'Baking Science & Technology', | ||
'Biology' | ||
] | ||
|
||
# Incomplete List | ||
DEGREE_TYPES = [ | ||
'Bachelors Degree (Bachelor of Science or Arts)' | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,29 @@ | ||
COUNTRY_REGION_CODE_LABEL = 'fbclc_ituCode' | ||
COUNTRY_REGION_OF_RESIDENCE_LABEL = 'fbclc_country' | ||
CITIZEN_QUESTION_LABEL = '154:_select' | ||
COUNTRY_OF_ORIGIN_LABEL = '195:_select' | ||
EIGHTEEN_YEARS_OLD_LABEL = '211:_select' | ||
REQUIRE_SPONSORSHIP_LABEL = '215:_select' | ||
PREVIOUSLY_WORKED_LABEL = '219:_select' | ||
PREVIOUSLY_PARTNERED_LABEL = '223:_select' | ||
RELATIVE_WORKER_LABEL = '227:_select' | ||
ESSENTIAL_FUNCTIONS_LABEL = '231:_select' | ||
GENDER_LABEL = '235:_select' | ||
|
||
# Candidate-Specific Information | ||
CITIZEN_QUESTION_LABEL = 'citizen' | ||
COUNTRY_OF_ORIGIN_LABEL = 'custCountry' | ||
EIGHTEEN_YEARS_OLD_LABEL = 'custAge' | ||
REQUIRE_SPONSORSHIP_LABEL = 'cust_sponsor' | ||
PREVIOUSLY_WORKED_LABEL = 'custPrev' | ||
PREVIOUSLY_PARTNERED_LABEL = 'custcontr' | ||
RELATIVE_WORKER_LABEL = 'custRel' | ||
ESSENTIAL_FUNCTIONS_LABEL = 'custAccom' | ||
GENDER_LABEL = 'custgender' | ||
REFERRAL_LABEL = 'candidateSource' | ||
ETHNICITY_LABEL = 'ethnicity' | ||
DISABILITY_LABEL = 'disabilityselection' | ||
|
||
# Captcha | ||
RECAPTCHA_AUDIO_BUTTON = 'recaptcha-audio-button' | ||
RECAPTCHA_ANCHOR = 'recaptcha-anchor' | ||
AUDIO_SOURCE = 'audio-source' | ||
AUDIO_RESPONSE = 'audio-response' | ||
|
||
# Profile Information | ||
STATE_LABEL = 'state' | ||
PRESENT_EMPLOYEE = 'presentEmployer' | ||
|
||
# Outside Work Experience | ||
INDUSTRY_LABEL = 'VFLD2' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance you could merge in #51 and have the resume & website agree on university and degree? Otherwise, this looks fantastic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged in the latex_resumes. The university is auto-filled from the resume, so luckily we don't have to touch that. I still need to copy the long list of degree majors from the site's dropdown list.
Because the "major/area of study" field is a dropdown, I need specific strings in order to match the selection (I can't type my own option). To make this easier, once I copy over the list of majors, could you modify the resume generator to only use those major names?
The list of majors will be in "common.py" under the variable name "DEGREE_MAJORS"
Also I can't be sure if its still working after the merge, cause email verification. Hopefully there'll be a fix in a few hours when I have time to work on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, should be an easy fix. It’ll likely auto-populate once that’s done, won’t it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe it's capable of auto-populating dropdown menus. I'm writing a summary of the auto-fill behavior I've noticed and I'll comment it on your PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if
make_resume()
returned the university and degree it chose, so thatmain.py
can use those same values to “manually” fill those dropdowns? or, alternatively (or simultaneously),make_resume()
accepteduniversity
andjob
as optional parameters, so thatmain.py
could generate them and pass them along just like it does withname
,email
, andphone
?I can experiment with both of those with my own commits, if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could store degree names in a dict, like:
(or even define a small
degree
object, if we want to be fancy). That way we wouldn’t have to worry about parsing from one to the other.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of storing everything in
fake_identity
for sure.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok as I'm looking through
resume_faker.py
, I think we're overcomplicating things. Everything currently in that file is a Bachelor's Degree of some sort, so they all correspond to "Bachelors Degree (Bachelor of Science or Arts)". Simple as thatWe could add in a bunch of associates degrees as a separate list if we want to mix up the results, then they would all correspond to "Associates Degree/Diploma" in the form. I think these degrees are most in line with what Kelloggs would actually be looking for, and they're extremely common degrees, so we could just keep it at that.
Thinking about adding "High School Diploma" as well, but I'm realizing that if there isn't a college listed on the resume, the form won't autofill the college. Maybe we can experiment with putting high school names in the resume and seeing if the form still auto-fills the education section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you’re right about us overcomplicating it. We could add associate’s degrees, but i’m not so sure we should be worrying about a recruiter being able to manually tell the difference between a fake resume and a real one (the bullet points are all gibberish anyway), so i don’t think the specific degree matters much (in my opinion).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let's just keep it to Bachelors Degrees only (which is how it already is) and a random major. So I just need to add in the rest of the majors and this will all be dealt with