Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove separate WithQuery to ensure it can be specified everywhere #814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bouk
Copy link

@bouk bouk commented Sep 6, 2024

Instead, move the with clause into insert/update/select/delete. This makes sure you can specify with WITH clause to any method that takes a SelectStatement/UpdateStatement/InsertStatement/DeleteStatement.

PR Info

Breaking Changes

  • This removes WithQuery and changes the signature of .with()

Instead, move the with clause into insert/update/select/delete.

Fixes SeaQL#813
@tyt2y3
Copy link
Member

tyt2y3 commented Oct 1, 2024

Thank you for your contribution. While I appreciate now that we can use a with clause in all statement types, removing WithQuery is breaking. Is there a middleground where we still keep it?

@bouk
Copy link
Author

bouk commented Oct 8, 2024

We could keep both kinds and deprecate WithQuery, removing it in a later version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify SelectStatement and WithQuery
2 participants