Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for broken periodic tasks, errors during project creation + other small fixes #239

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

akochari
Copy link
Collaborator

@akochari akochari commented Oct 14, 2024

Description

This PR contains two bugfixes: SS-1163 - periodic tasks cleaning up notebooks and file managers were not working; SS-1136 - we were getting unnecessary error warnings for project-vol and project-netpolicy not having 'access' fields but they were not supposed to have that anyway.

In addition this PR contains the following minor changes:

SS-1186 - remove legacy environments from default project template
SS-1184 - add lth.se to the list of whitelisted email domains

  • allow only lowercase letters in email field for granting access

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

@akochari akochari added the bug Something isn't working label Oct 14, 2024
@akochari akochari marked this pull request as ready for review October 14, 2024 14:29
@akochari akochari changed the title Fixes for broken period tasks, errors during project creation + other small fixes Fixes for broken periodic tasks, errors during project creation + other small fixes Oct 15, 2024
Copy link
Member

@alfredeen alfredeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants