Ss 643 make an option to edit account details #235
+310
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Viktor Sandström <[email protected]>
This reverts commit d321a3f.
churnikov
reviewed
Oct 8, 2024
churnikov
requested changes
Oct 9, 2024
churnikov
reviewed
Oct 15, 2024
Comment on lines
+189
to
+203
| user_form_details = self.user_edit_form_class( | ||
| request.POST, | ||
| instance=request.user, | ||
| initial={ | ||
| "email": user_profile_data.user.email, | ||
| }, | ||
| ) | ||
|
|
||
| profile_form_details = self.profile_edit_form_class( | ||
| request.POST, | ||
| instance=user_profile_data, | ||
| initial={ | ||
| "affiliation": user_profile_data.affiliation, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Please make sure, that user cannot pass any other information in the form data.
For instance, that user via direct curl request cannot change their email or password.
| ] | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| super(ProfileEditForm, self).__init__(*args, **kwargs) |
There was a problem hiding this comment.
Suggested change
| super(ProfileEditForm, self).__init__(*args, **kwargs) | |
| super().__init__(*args, **kwargs) |
removed comments Co-authored-by: Nikita Churikov <[email protected]>
fixed the gap after hash sign Co-authored-by: Nikita Churikov <[email protected]>
changed the comment text Co-authored-by: Nikita Churikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference: SS-643
It should be an option under the Profile dropdown. Users can update their first name, last name, and department. The university and email will be shown but can't be edited. There should be a note on the page saying that to change email or university affiliation, they need to contact [email protected].
Types of changes
new feature
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!