Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/shinyproxy #68

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Feature/shinyproxy #68

merged 8 commits into from
Oct 11, 2023

Conversation

hamzaimran08
Copy link
Contributor

Adding the image for shinyproxy

@hamzaimran08 hamzaimran08 marked this pull request as draft October 9, 2023 21:56
@hamzaimran08 hamzaimran08 marked this pull request as ready for review October 10, 2023 07:45
@hamzaimran08 hamzaimran08 requested a review from a team October 10, 2023 11:11
sandstromviktor
sandstromviktor approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@sandstromviktor sandstromviktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great! Tests pass and the Dockerfile looks fine!

@sandstromviktor sandstromviktor merged commit ec1b50a into main Oct 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandstromviktor sandstromviktor sandstromviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamzaimran08 @sandstromviktor