Work on portal's About page and Privacy page #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HomePage and other files to make it work. Better organized now imo
Merging some work on AboutPage, changes also touched other components and files so a lot of more general changes were made in AboutPage branch.
Merging some minor polishing done for index page and related components.
…asses is problematic, keep hardcoding
Fixed an issue with spacing in the about page.
…t responsive to different screen sizes
Minor edit to fix component scaling to look better on laptop after scaling it to a huge screen.
…etting checked={true} for all made it work. Assume DaisyUI already has a function doing that in the background?
…tabs on About page
…utPage but accidentally added it in this active branch
Merging work on About Page, including separating the different components into child routes for the about page, using and adapting new components, adjusting styling. Also accidentally added content to public in this branch, though it is not specifically related to the about page (yet).
…ould work on a more dynamic solution that can extract text from file as it will be written in markdown format by Natashia.
Merging work on privacy page. Have hardcoded some text by copy pasting Natashia's work into the tsx file. Will work on a more dynamic solution in the future, but need to inform Natashia about how she formats the files first (currently in rich text format which includes formating tokens in file, making it difficult to use programmatically.)
JanProgrammierung
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this PR will introduce an about page and a privacy page designed after specs given in Figma. Currently they have some minor issues that will need to be worked on later, but the pages function pretty much as they should.
Adapted the card components from DaisyUI so that we can use the same component with different configurations (with/without image, button, title and so on).
Added accordion component from DaisyUI. Not quite sure how it actually works under the hood yet so it is a bit wonky. It basically works as it should but one of the bars seems to always have to be open, which looks a bit weird in my opinion (in other words, as soon as you enter the FAQ section it looks as if you've already clicked one of the options.)
Created the different about page tabs using routing and adding them as children to the about path. In other words, clicking the different tabs sends you to about/product, about/faq and about/partners respectively. Currently it works fine, but the actual tab component doesn't look like it should. I think this is because I changed it from an anchor element to a react-router-dom NavLink element, which might have broken some of the DaisyUI config for the component. Can probably make it look right with some tailwind settings, but will take some figuring out.
Other than that, I have played around with padding, spacing, flex cols/rows to try to give everything a bit more space and be more consistent. I have also tried to organize some of the repeated tailwind classes into constants and added some more interfaces to make the code a bit more organized and readable (in my opinion). This will be ongoing and will probably change a lot more with time, since I'm learning React, Typsecript and web dev as I go.