Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout to v4 #1556

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Bump actions/checkout to v4 #1556

wants to merge 3 commits into from

Conversation

valyo
Copy link
Member

@valyo valyo commented Sep 25, 2024

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Bump checkout action to v4, after noticing warning:
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Prettier
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk

@valyo valyo requested a review from a team as a code owner September 25, 2024 10:14
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (3414ef7) to head (e2327c9).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1556   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          29       29           
  Lines        4868     4868           
=======================================
  Hits         4504     4504           
  Misses        364      364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprintlog and check the scan boxes

@valyo valyo requested a review from i-oden September 27, 2024 09:12
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if we shouldn't update all instances of actions/checkout@v4 and not only this workflow file?

Also, I updated the branch and resolved the sprintlog, and now checks are failing again, not sure why?

@rv0lt
Copy link
Member

rv0lt commented Oct 8, 2024

Just wondering if we shouldn't update all instances of actions/checkout@v4 and not only this workflow file?

Also, I updated the branch and resolved the sprintlog, and now checks are failing again, not sure why?

Again the too many requests, if you run it locally with the vpn it also hits it. Yesterday it also happened a lot with the PRs. They must have decreased the limits recently or there is something that changed, because it is too much of a coincidence now

I read somewhere a solution to cache images to avoid pulling them in the Actions everytime, only solution for now is to re-run the jobs after a time

image

@i-oden
Copy link
Member

i-oden commented Oct 9, 2024

Just wondering if we shouldn't update all instances of actions/checkout@v4 and not only this workflow file?
Also, I updated the branch and resolved the sprintlog, and now checks are failing again, not sure why?

Again the too many requests, if you run it locally with the vpn it also hits it. Yesterday it also happened a lot with the PRs. They must have decreased the limits recently or there is something that changed, because it is too much of a coincidence now

I read somewhere a solution to cache images to avoid pulling them in the Actions everytime, only solution for now is to re-run the jobs after a time

image

🙃

Copy link
Member Author

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I cannot "Approve" or "Request changes" here, only "Comment".
It looks good, maybe as Ina suggested we should bump this action in all our workflows.

@i-oden
Copy link
Member

i-oden commented Oct 16, 2024

For some reason I cannot "Approve" or "Request changes" here, only "Comment". It looks good, maybe as Ina suggested we should bump this action in all our workflows.

@valyo You can't approve because you created the PR 😄 So you're the one making potential changes to the other actions as well

@valyo
Copy link
Member Author

valyo commented Oct 16, 2024

For some reason I cannot "Approve" or "Request changes" here, only "Comment". It looks good, maybe as Ina suggested we should bump this action in all our workflows.

@valyo You can't approve because you created the PR 😄 So you're the one making potential changes to the other actions as well

🙃
this explains a lot

@valyo
Copy link
Member Author

valyo commented Oct 16, 2024

ok, if we have agreed that all actions should be bumped, I'll add the changes in this PR

@i-oden
Copy link
Member

i-oden commented Oct 16, 2024

ok, if we have agreed that all actions should be bumped, I'll add the changes in this PR

Yes go ahead and do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants