perf: testing the newer nonlinear solve versions #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there was probably a merge with the signature not updated. @thazhemadam can you update it on master? |
|
Done in #1078. |
|
@avik-pal it looks like it worked? Let me know if this should revert, but it looks fine to me. |
|
This is using a commit which won't exist now. Let's revert for now. I want to refresh the benchmarks next week with DI's sparsity stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly to check SciML/NonlinearSolve.jl#468
I am nearly certain I need to make other changes to get this to work but lets see