Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update for MTKv9 #685

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Conversation

AayushSabharwal
Copy link
Member

I'll separate this PR out into another one that contains changes independent of v9

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.84%. Comparing base (a65ef30) to head (d4f90fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #685       +/-   ##
===========================================
+ Coverage    8.65%   40.84%   +32.18%     
===========================================
  Files          31       31               
  Lines        2506     2522       +16     
===========================================
+ Hits          217     1030      +813     
+ Misses       2289     1492      -797     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/cache.jl Outdated Show resolved Hide resolved
@AayushSabharwal
Copy link
Member Author

The type-piracy removal is now in #689 so it can be merged independent of MTKv9

@ChrisRackauckas
Copy link
Member

Does this still need to be a draft?

@ChrisRackauckas
Copy link
Member

Test failure.

@AayushSabharwal
Copy link
Member Author

MOI tests pass locally, I'm not sure why it doesn't resolve here. MTK probably doesn't pass because it isn't using the local OptimizationMOI

@@ -19,7 +20,7 @@ Ipopt = "1"
Ipopt_jll = "300.1400"
Juniper = "0.9"
MathOptInterface = "1"
ModelingToolkit = "8.74"
ModelingToolkit = "9"
Copy link
Member

@Vaibhavdixit02 Vaibhavdixit02 Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The downgrade MOI one fails because you have removed 8.74 here but not in Optimization.jl's project.toml

@ChrisRackauckas
Copy link
Member

Passes now!

@ChrisRackauckas
Copy link
Member

The docs failures look real.

@AayushSabharwal
Copy link
Member Author

Docs are probably failing because It's using OptimizationMOI v0.1.16. Bumping MTK compat makes it use v0.1.9 which is weird.

@AayushSabharwal
Copy link
Member Author

So I can fix compat, but CI doesn't checkout the subpackages (specifically OptimizationMOI) so they won't build here

@AayushSabharwal
Copy link
Member Author

Also docs doesn't have compat for the latest version of

  • OptimizationPRIMA
  • OptimizationSpeedMapping
    And OptimizationQuadDIRECT requires a different registry entirely

I'm trying to build docs locally by bumping compat for the first two packages and deving all the packages except QuadDIRECT. If it builds, should I also update CI?

@ChrisRackauckas ChrisRackauckas merged commit 16f862c into SciML:master Feb 27, 2024
24 of 43 checks passed
@AayushSabharwal AayushSabharwal deleted the as/mtk-v9 branch February 27, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants