map maxiters to outer_iterations

[SebastianM-C]

Fix #508

I implemented #508 (comment) here, but I'm not sure how to test it.

cc @Vaibhavdixit02 @ChrisRackauckas

[codecov]

Codecov Report

Merging #544 (073f507) into master (09cc1e7) will decrease coverage by 6.71%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #544      +/-   ##
=========================================
- Coverage    8.87%   2.16%   -6.71%     
=========================================
  Files          40      40              
  Lines        2669    2673       +4     
=========================================
- Hits          237      58     -179     
- Misses       2432    2615     +183     

Files	Coverage Δ
lib/OptimizationOptimJL/src/OptimizationOptimJL.jl	0.00% <0.00%> (-62.43%)	⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ChrisRackauckas]

is it always outer iterations or only when it's fminbox?

[SebastianM-C]

ah, good point. should it be outer_iterations only when we have bounds and iterations otherwise?

[ChrisRackauckas]

I think so, and this needs a test

[Vaibhavdixit02]

We should actually switch to using both local_maxiters and maxiters with local_maxiters getting passed on as iterations and maxiters to outer_iterations

[Vaibhavdixit02]

@SebastianM-C you might want to pull and rebase, sorry! 😅

[ChrisRackauckas]

Is this ready to go?

[SebastianM-C]

I think it should be fine now.
@Vaibhavdixit02 let me know if the logic is correct now.

[Vaibhavdixit02]

Will merge once Optim tests pass, thanks!