Merge pull request #691 from jonathanfischer97/master

Fixed issue #683: error when `store_trace=true` in OptimizationEvolutionary.jl
SciML · Feb 2, 2024 · a2ed16c · a2ed16c
2 parents d879158 + 661bcf5
commit a2ed16c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/OptimizationEvolutionary/src/OptimizationEvolutionary.jl b/lib/OptimizationEvolutionary/src/OptimizationEvolutionary.jl
@@ -90,7 +90,7 @@ function SciMLBase.__solve(cache::OptimizationCache{
             u = curr_u,
             objective = x[1],
             original = trace)
-        cb_call = cache.callback(opt_state, trace.value...)
+        cb_call = cache.callback(opt_state, decompose_trace(trace).value...)
         if !(cb_call isa Bool)
             error("The callback should return a boolean `halt` for whether to stop the optimization process.")
         end

diff --git a/lib/OptimizationEvolutionary/test/runtests.jl b/lib/OptimizationEvolutionary/test/runtests.jl
@@ -42,4 +42,7 @@ Random.seed!(1234)
         return false
     end
     sol = solve(prob, CMAES(μ = 40, λ = 100), callback = cb, maxiters = 100)
+
+    #test that `store_trace=true` works now. Threw ""type Array has no field value" before.
+    solve(prob, CMAES(μ = 40, λ = 100), store_trace = true)
 end