Fix optim maxsense

SciML · Nov 2, 2023 · 3db7393 · 3db7393
1 parent 29d5407
commit 3db7393
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl b/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl
@@ -160,7 +160,7 @@ function SciMLBase.__solve(cache::OptimizationCache{
         if G !== nothing
             cache.f.grad(G, θ, cur...)
             if cache.sense === Optimization.MaxSense
-                G .*= false
+                G .*= -one(eltype(G))
             end
         end
         return _loss(θ)
@@ -170,22 +170,22 @@ function SciMLBase.__solve(cache::OptimizationCache{
         hv = function (H, θ, v)
             cache.f.hv(H, θ, v, cur...)
             if cache.sense === Optimization.MaxSense
-                H .*= false
+                H .*= -one(eltype(H))
             end
         end
         optim_f = Optim.TwiceDifferentiableHV(_loss, fg!, hv, cache.u0)
     else
         gg = function (G, θ)
             cache.f.grad(G, θ, cur...)
             if cache.sense === Optimization.MaxSense
-                G .*= false
+                G .*= -one(eltype(G))
             end
         end
 
         hh = function (H, θ)
             cache.f.hess(H, θ, cur...)
             if cache.sense === Optimization.MaxSense
-                H .*= false
+                H .*= -one(eltype(H))
             end
         end
         u0_type = eltype(cache.u0)
@@ -273,7 +273,7 @@ function SciMLBase.__solve(cache::OptimizationCache{
         if G !== nothing
             cache.f.grad(G, θ, cur...)
             if cache.sense === Optimization.MaxSense
-                G .*= false
+                G .*= -one(eltype(G))
             end
         end
         return _loss(θ)
@@ -282,7 +282,7 @@ function SciMLBase.__solve(cache::OptimizationCache{
     gg = function (G, θ)
         cache.f.grad(G, θ, cur...)
         if cache.sense === Optimization.MaxSense
-            G .*= false
+            G .*= -one(eltype(G))
         end
     end
     optim_f = Optim.OnceDifferentiable(_loss, gg, fg!, cache.u0)
@@ -356,22 +356,22 @@ function SciMLBase.__solve(cache::OptimizationCache{
         if G !== nothing
             cache.f.grad(G, θ, cur...)
             if cache.sense === Optimization.MaxSense
-                G .*= false
+                G .*= -one(eltype(G))
             end
         end
         return _loss(θ)
     end
     gg = function (G, θ)
         cache.f.grad(G, θ, cur...)
         if cache.sense === Optimization.MaxSense
-            G .*= false
+            G .*= -one(eltype(G))
         end
     end
 
     hh = function (H, θ)
         cache.f.hess(H, θ, cur...)
         if cache.sense === Optimization.MaxSense
-            H .*= false
+            H .*= -one(eltype(H))
         end
     end
     u0_type = eltype(cache.u0)