refactor!: require systems to be completed before creating XProblem/XProblemExpr
#2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Requires SciML/Optimization.jl#690 and SciML/SciMLBase.jl#603 for tests to pass |
AayushSabharwal
force-pushed
the
as/require-completed
branch
from
3256ae2
to
0a1188b
Compare
|
CI won't pass here because of the states->unknowns change, but it runs locally |
|
As before, CI passes except not all of |
|
Resolve conflicts |
…ion`/`XFunctionExpr`
AayushSabharwal
force-pushed
the
as/require-completed
branch
from
24ffacc
to
a779f4b
Compare
| @@ -73,7 +73,7 @@ function UnitMassWithFriction(k; name) | |||
| ODESystem(eqs, t; continuous_events = [v ~ 0], name) # when v = 0 there is a discontinuity | |||
| end | |||
| @named m = UnitMassWithFriction(0.7) | |||
There was a problem hiding this comment.
Can we update all of these to @mtkbuild instead?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.