-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add files for landingpage #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the yaml linting is broken
will request a new one with fixes.. maybe I shouldn't have closed this one... |
let's try to fix here, it's going to be confusing to have new PRs just for fixes. Just do new commits |
this commit 396f9ec should fix the errors. How can one relaunch the checks? |
the tests have just rerun by they brake. An easy fix is to use the image from latest for the LP and use the usual image:latest format. anyway we will need to change that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that it runs the tests, can we please tackle the comments? Also the home page readme will need to be updated, both in the diagram and in the configuration section
blocked by #183 |
depends on: SciCatProject/LandingPageServer#375 |
Add config Add README Add documentation to main README Add landingpage to main compose.yaml includes
Update README with HTTPS changes
Add DEV instructions to landingpage README
initial step for adding lp as service to scicatlive