add files for landingpage #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will request a new one with fixes.. maybe I shouldn't have closed this one... |
|
let's try to fix here, it's going to be confusing to have new PRs just for fixes. Just do new commits |
|
this commit 396f9ec should fix the errors. How can one relaunch the checks? |
|
the tests have just rerun by they brake. An easy fix is to use the image from latest for the LP and use the usual image:latest format. anyway we will need to change that later. |
minottic
reviewed
Jun 19, 2024
minottic
reviewed
Jun 20, 2024
|
blocked by #183 |
minottic
reviewed
Jun 20, 2024
minottic
reviewed
Jun 20, 2024
|
depends on: SciCatProject/LandingPageServer#375 |
Add config Add README Add documentation to main README Add landingpage to main compose.yaml includes
Update README with HTTPS changes
Add DEV instructions to landingpage README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial step for adding lp as service to scicatlive