Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sdk generation error caused by incorrect swagger decorator #1455

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

Junjiequan
Copy link
Contributor

Description

This PR aims to fix SDK generation error caused by incorrect swagger decorator.

The changes include:

  • Replaced incorrect @ApiParam with @ApiBody in published-data controller
  • Set a default value for the status field in the PublishedData schema to "pending_registration".

Motivation

The github workflow for uploading latest SDK artifact dysfunctioning.

Fixes:

Please provide a list of the fixes implemented by this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

@Junjiequan Junjiequan changed the title fix: use @ApiBody decorator for body parameters fix: sdk generation error caused by incorrect swagger decorator Oct 23, 2024
@Junjiequan Junjiequan merged commit 473d23d into master Oct 23, 2024
10 checks passed
@Junjiequan Junjiequan deleted the schema-fix branch October 23, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants