Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding dataset start time #1366

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

nitrosx
Copy link
Contributor

@nitrosx nitrosx commented Aug 9, 2024

Description

This PR add the field startTime to raw datasets to match the field endTime.

Motivation

We were using scientific metadata to store start and end time of a data acquisition, without using the endTime field.
We wanted to enforce consistency and have both information in the high level fields of the datasets

Fixes:

  • datasets dto and schemas

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

@nitrosx nitrosx changed the title Feature adding dataset start time Feat: adding dataset start time Aug 9, 2024
@nitrosx nitrosx changed the title Feat: adding dataset start time feat: adding dataset start time Aug 9, 2024
@Junjiequan Junjiequan force-pushed the feature_adding_dataset_start_time branch from 197c852 to 2db48d1 Compare August 13, 2024 11:10
@Junjiequan
Copy link
Contributor

Junjiequan commented Aug 20, 2024

Error: ception during run: n [Error]: Max -730985476 should be greater than min 0.
[0]     at y.int (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/@faker-js/faker/dist/cjs/modules/number/index.js:1:859)
[0]     at T.between (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/@faker-js/faker/dist/cjs/modules/date/index.js:1:2136)
[0]     at faker.helpers.multiple.count (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/@faker-js/faker/dist/cjs/modules/date/index.js:1:2482)
[0]     at Function.from (<anonymous>)
[0]     at ee.multiple (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/@faker-js/faker/dist/cjs/modules/helpers/index.js:1:8233)
[0]     at T.betweens (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/@faker-js/faker/dist/cjs/modules/date/index.js:1:2464)
[0]     at Object.<anonymous> (/home/runner/work/scicat-backend-next/scicat-backend-next/test/TestData.js:9:33)
[0]     at Module._compile (node:internal/modules/cjs/loader:1358:14)
[0]     at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
[0]     at Module.load (node:internal/modules/cjs/loader:1208:32)
[0]     at Module._load (node:internal/modules/cjs/loader:1024:12)
[0]     at Module.require (node:internal/modules/cjs/loader:1233:19)
[0]     at require (node:internal/modules/helpers:179:18)
[0]     at Object.<anonymous> (/home/runner/work/scicat-backend-next/scicat-backend-next/test/Auth.js:2:22)
[0]     at Module._compile (node:internal/modules/cjs/loader:1358:14)
[0]     at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
[0]     at Module.load (node:internal/modules/cjs/loader:1208:32)
[0]     at Module._load (node:internal/modules/cjs/loader:1024:12)
[0]     at cjsLoader (node:internal/modules/esm/translators:348:17)
[0]     at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:297:7)
[0]     at ModuleJob.run (node:internal/modules/esm/module_job:222:25)
[0]     at async ModuleLoader.import (node:internal/modules/esm/loader:316:24)
[0]     at async formattedImport (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
[0]     at async exports.requireOrImport (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
[0]     at async exports.loadFilesAsync (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
[0]     at async singleRun (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/mocha/lib/cli/run-helpers.js:162:3)
[0]     at async exports.handler (/home/runner/work/scicat-backend-next/scicat-backend-next/node_modules/mocha/lib/cli/run.js:375:5)
[0] wait-on http://localhost:3000/explorer/ && npm run test:api:mocha exited with code 1
--> Sending SIGTERM to other processes..
[1] npm run start exited with code SIGTERM
Error: Process completed with exit code 1.

This error occured too many times. We need to check what is the cause before merge the PR.

@Junjiequan Junjiequan force-pushed the feature_adding_dataset_start_time branch from 08ab3e0 to 8ca1eae Compare August 22, 2024 11:11
@nitrosx nitrosx merged commit 9a3d8d0 into master Aug 22, 2024
8 checks passed
@nitrosx nitrosx deleted the feature_adding_dataset_start_time branch August 22, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants