Allow PROPOSAL_GROUPS members to update proposal
#1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bpedersen2 I guess it would make sense to also allow Attachement updates? |
nitrosx
approved these changes
Feb 9, 2024
|
Once this PR is merged we should review the permissions for all the other sub-systems. |
Junjiequan
force-pushed
the
proposalGroup-update-permission
branch
from
8ab6024
to
3935955
Compare
Junjiequan
force-pushed
the
proposalGroup-update-permission
branch
from
3935955
to
390f3cd
Compare
|
@nitrosx based on the Authorization table in the Documentation this is valid change and can be mreged |
Junjiequan
force-pushed
the
proposalGroup-update-permission
branch
from
390f3cd
to
fb13ae8
Compare
Junjiequan
force-pushed
the
proposalGroup-update-permission
branch
from
fb13ae8
to
695c520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
PROPOSAL_GROUPSmembers to update proposal.Motivation
In the proposal ingestion workflow, we first ingest the proposal and each time a measurement period is scheduled/removed, it's updated in SciCat.
I'll update the corresponding documentation before merging if the patch is accepted.
Tests included/Docs Updated?