Merge pull request #1222 from SciCatProject/build(deps)--bump-mongoos…

…e-from-8.3.1-to-8.4.0

build(deps): bump mongoose from 8.3.1 to 8.4.0

package.json

@@ -57,7 +57,7 @@
     "luxon": "^3.2.1",
     "mathjs": "^12.0.0",
     "migrate-mongo": "^11.0.0",
-    "mongoose": "^8.3.1",
+    "mongoose": "^8.4.0",
     "node-fetch": "^3.3.0",
     "nodemailer": "^6.7.8",
     "openid-client": "^5.1.8",

src/datasets/datasets.service.ts

@@ -64,10 +64,8 @@ export class DatasetsService {
       // insert created and updated fields
       addCreatedByFields(createDatasetDto, username),
     );
-    if (this.ESClient) {
-      await this.ESClient.updateInsertDocument(
-        createdDataset.toObject() as DatasetDocument,
-      );
+    if (this.ESClient && createdDataset) {
+      await this.ESClient.updateInsertDocument(createdDataset.toObject());
     }
     return createdDataset.save();
   }
@@ -242,10 +240,8 @@ export class DatasetsService {
       throw new NotFoundException(`Dataset #${id} not found`);
     }
 
-    if (this.ESClient) {
-      await this.ESClient.updateInsertDocument(
-        updatedDataset.toObject() as DatasetDocument,
-      );
+    if (this.ESClient && updatedDataset) {
+      await this.ESClient.updateInsertDocument(updatedDataset.toObject());
     }
     // we were able to find the dataset and update it
     return updatedDataset;
@@ -283,10 +279,8 @@ export class DatasetsService {
       )
       .exec();
 
-    if (this.ESClient) {
-      await this.ESClient.updateInsertDocument(
-        patchedDataset?.toObject() as DatasetDocument,
-      );
+    if (this.ESClient && patchedDataset) {
+      await this.ESClient.updateInsertDocument(patchedDataset.toObject());
     }
 
     // we were able to find the dataset and update it

src/elastic-search/elastic-search.service.ts

@@ -359,7 +359,7 @@ export class ElasticSearchService implements OnModuleInit {
       );
     }
   }
-  async updateInsertDocument(data: DatasetDocument) {
+  async updateInsertDocument(data: Partial<DatasetDocument>) {
     //NOTE: Replace all keys with lower case, also replace spaces and dot with underscore
     delete data._id;
     const transformedScientificMetadata = transformKeysInObject(