V4 datasets #40
Merged
V4 datasets #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using `pip install -e ".[option]"`. To add optional requirements add to the [optional.extras_require] in the setup config. All functions and imports work the same way. Restructured the testing suite so it follows a similar pattern. All tests pass.
…t. The versioneer part of the set up config will set the version and does not need to be written in the metadata section
…int then this is treated by urllib.parse like a full path.
…ignored by the current actions workflows.
…from the setup config.
Closed
dylanmcreynolds
approved these changes
Jun 6, 2023
nitrosx
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are a start for the v4 rebase. Here I have focused on the datasets endpoint only. If other endpoints have changed they will need to be fixed in subsequent PRs.
I originally submitted this request as v4.y #38 which branched off #39 . For more details please see that PR. I have now moved these changes to branch off master so that the tests pass and the corrections have been made for the dataset endpoint only.