Add cls Qubit and QuantumRegister #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhaoyilunnn
reviewed
Aug 2, 2023
src/quafu/circuits/qreg.py
Outdated
Comment on lines
68
to
80
| if __name__ == '__main__': | ||
| # q0 = Qubit(0) | ||
| # q1 = Qubit(1) | ||
| # reg = {q.pos: q for q in [q0, q1]} | ||
| # print(reg) | ||
| # | ||
| # reg[0], reg[1] = reg[1], reg[0] | ||
| # reg[0].pos, reg[1].pos = reg[1].pos, reg[0].pos | ||
| # | ||
| # print(reg) | ||
| # print([q0.pos, q1.pos]) | ||
| reg = QuantumRegister(4, name='reg') | ||
| print(reg[3]) |
There was a problem hiding this comment.
Suggest not to put test/example code here.
There was a problem hiding this comment.
Yes, this part has been removed.
src/quafu/circuits/qreg.py
Outdated
Comment on lines
59
to
62
| def __add__(self, other: 'QuantumRegister'): | ||
| qreg = QuantumRegister(name=self.name) | ||
| qreg.qubits = {**{self.qubits}, **{i + len(self): qubit for i, qubit in other.qubits.item()}} | ||
| return QuantumRegister(len(self) + len(other), name=self.name) |
There was a problem hiding this comment.
Can we have an inplace method, i.e., not to create a new cls
sth like this: self.qubits.update({i + len(self): qubit for i, qubit in other.qubits.items()}) , define an __iadd__
There was a problem hiding this comment.
Of course, yet this function was merely defined here as a reminder for future development. Let's see whether it will be actually needed.
Yet decorator implementation may be adopted in the future to provide cleaner coding and more flexible usage.
Yet decorator implementation may be adopted in the future to provide cleaner coding and more flexible usage.
Zhaoyilunnn
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see qreg.py for details, to be incorporated into Circuit and visualisation.