Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set IsPlaying property of MediaElementBase after call Pause() method #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-buraykin
Copy link

Fix #56

@xmedeko
Copy link
Collaborator

xmedeko commented Oct 3, 2017

I am not the original author of this code, so I do not know the intent why it has been made this way. But I guess that SetIsPlaying(true) is called when the video really plays. SetIsPlaying(false) is called just when there's an intent to stop the video.

E.g. if you have a button <Button Content="Pause" Enabled="{Binding IsPlaying, ElementName=player", then it is disabled as soon as the Pause() is called - the button is pressed. After your change, it may be disabled a moment after the button is pressed, so the user may press it twice.

What's your use case - reason for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants