Fix navigation drawer #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an ugly workaround in which the nav buttons are wrapped in Drawer.Close onditionally to avoid having to programmatically control open. Programmatically controlling open causes issues: - the drawer close animation doesn't play; it just disappears instantly - the drawer close momentarily resets scroll on iOS/safari Also add meta tags for discord embed, and remove second image tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an ugly workaround in which the nav buttons are wrapped in Drawer.Close conditionally to avoid having to programmatically control open. Programmatically controlling open causes issues:
Also add meta tags for discord embed, and remove second image tag