Use IOptionsMonitor to hot reload config #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SapiensAnatis
added a commit
that referenced
this pull request
Jun 30, 2024
I was operating under the mistaken assumption that `IOptions<T>` represented the config value at the time of injection and that you only needed `IOptionsMonitor<T>` if you expected the value to change while you were holding on to the instance... Turns out `IOptions<T>` does not reload at all at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was operating under the mistaken assumption that
IOptions<T>represented the config value at the time of injection and that you only neededIOptionsMonitor<T>if you expected the value to change while you were holding on to the instance...Turns out
IOptions<T>does not reload at all at runtime.