Update PhotonStateManager related configuration #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could solve the issue of the API having to re-template and restart each time the state manager is deployed, due to the fact that Nomad selects a random port for the state manager. Previously this has been solved by using the public URL however this results in going through Cloudflare and Caddy again. I could also put the state manager on a static port, but I'm not sure whether Consul would still re-template in the 5 second window that the service is deleted. This is also recommended against in the docs as it makes it harder for Nomad to schedule jobs.
- Remove ENABLE_HTTPS env var in favour of official config - Remove PHOTON_TOKEN env var from both projects - Update PSM Program.cs to better use IOptions
SapiensAnatis
changed the title
SapiensAnatis
added a commit
that referenced
this pull request
Jun 30, 2024
- Adds support for the [key-per-file](https://learn.microsoft.com/en-us/dotnet/core/extensions/configuration-providers#key-per-file-configuration-provider) configuration provider to the app. - Also fixes the lambda for adding `IPhotonStateApi` to make it pull an updated value for the base URL. - Miscellaneous refactoring to PhotonStateManager config, including better use of DI and `IConfiguratioon`. This includes several breaking changes for PhotonStateManager: - `PHOTON_TOKEN` environment variable -> `PhotonOptions__Token` - `ENABLE_HTTPS` environment variable no longer used, consult ASP.NET docs for alternative --- This is primarily intended to solve the issue of the API having to re-template and restart each time the state manager is deployed, due to the fact that Nomad selects a random port for the state manager. Currently the URL is stored as an env variable which requires a container restart to reflect a change. Previously this has been solved by using the public URL however this results in going through Cloudflare and Caddy again. I could also put the state manager on a static port, but I'm not sure whether Consul would still re-template in the 5 second window that the service is deleted. This is also recommended against in the docs as it makes it harder for Nomad to schedule jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPhotonStateApito make it pull an updated value for the base URL.IConfiguratioon.This includes several breaking changes for PhotonStateManager:
PHOTON_TOKENenvironment variable ->PhotonOptions__TokenENABLE_HTTPSenvironment variable no longer used, consult ASP.NET docs for alternativeThis is primarily intended to solve the issue of the API having to re-template and restart each time the state manager is deployed, due to the fact that Nomad selects a random port for the state manager. Currently the URL is stored as an env variable which requires a container restart to reflect a change.
Previously this has been solved by using the public URL however this results in going through Cloudflare and Caddy again.
I could also put the state manager on a static port, but I'm not sure whether Consul would still re-template in the 5 second window that the service is deleted. This is also recommended against in the docs as it makes it harder for Nomad to schedule jobs.