Add indicator to fresh news posts #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an icon and a border around news posts that are new based on a local storage item that is set by the page. Also: - Move loading of news items from OnInitializedAsync to OnAfterRenderAsync. The former is called twice and causes a flicker, as well as a wasteful DB query. - Remove FocusOnNavigate that focused the title element on each page - Some minor refactoring of the cookie logic, from when I thought I would use cookies to store the last date
SapiensAnatis
added a commit
that referenced
this pull request
Jun 30, 2024
Adds an icon and a border around news posts that are new based on a local storage item that is set by the page indicating when it was last visited. Also: - Move loading of news items from OnInitializedAsync to OnAfterRenderAsync. The former is called twice and causes a flicker, as well as a wasteful DB query. - Remove FocusOnNavigate that focused the title element on each page - Some minor refactoring of the cookie logic, from when I thought I would use cookies to store the last date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an icon and a border around news posts that are new based on
a local storage item that is set by the page indicating when it was last visited.
Also:
OnAfterRenderAsync. The former is called twice and causes a flicker,
as well as a wasteful DB query.
would use cookies to store the last date