Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin retry fixes and refactoring #377

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Conversation

SapiensAnatis
Copy link
Owner

@SapiensAnatis SapiensAnatis commented Aug 8, 2023

Plugin refactoring:

  • Remove HeroParam and other custom actor properties and persist this state in the plugin class, since only the plugin needs to know about these. It's tidier and avoids Photon having to serialize them (and crashing in the case of HeroParam since we didn't register this type).
  • Use enums for event codes.
  • Improve logging and add info logs which can provide basic diagnostics, particularly around potential problem areas such as GoToIngameState

@SapiensAnatis SapiensAnatis merged commit 863d732 into develop Aug 9, 2023
7 checks passed
@SapiensAnatis SapiensAnatis deleted the fix/coop-fixes-8 branch August 9, 2023 17:46
SapiensAnatis added a commit that referenced this pull request Jun 30, 2024
- Closes #244, a.k.a. [Golden Experience
Requiem](https://www.youtube.com/watch?v=r_mfpy2ZyQQ) bug by returning
players to the lobby when retrying after at least one player has given
up.
- Retries when failing a quest are still a bit glitchy -- it's supposed
to remove players who voted no and allow players who voted yes to
optionally rejoin the room similar to the prompt on a successful clear.
Currently any retry where all players are dead will go back to the
lobby. #378 raised to track.

Plugin refactoring:
- Remove HeroParam and other custom actor properties and persist this
state in the plugin class, since only the plugin needs to know about
these. It's tidier and avoids Photon having to serialize them (and
crashing in the case of HeroParam since we didn't register this type).
- Use enums for event codes.
- Improve logging and add info logs which can provide basic diagnostics,
particularly around potential problem areas such as GoToIngameState
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Co-op retries should return to lobby when room is not full
1 participant