DungeonRecordController refactor #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
SapiensAnatis
commented
Jul 18, 2023
•
SapiensAnatis
commented
- Have DungeonRecordController call into several services to build the giant response object.
- Should enable easier unit testing and more extensibility
- Add logic to show helper_list of co-op teammates when finishing a co-op quest
SapiensAnatis
force-pushed
the
sapiensanatis/record-refactor
branch
from
c6a6de1
to
4b67fad
Compare
SapiensAnatis
force-pushed
the
sapiensanatis/record-refactor
branch
4 times, most recently
from
83125e0
to
29fa540
Compare
SapiensAnatis
changed the title
SapiensAnatis
force-pushed
the
sapiensanatis/record-refactor
branch
from
49ac456
to
28d12a7
Compare
SapiensAnatis
added a commit
that referenced
this pull request
Jun 30, 2024
- Have DungeonRecordController call into several services to build the giant response object. - Should enable easier unit testing and more extensibility - Add logic to show helper_list of co-op teammates when finishing a co-op quest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.