Optimize background image #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the background images into wide and narrow variants so that we don't end up loading the full image where half of it will not be seen because of screen size. The previous images were 384 KB for light mode, and 229 KB for dark mode. The new images are 145 KB / 166 KB for narrow/wide in light mode, and 83.8 KB / 104 KB for narrow/wide in dark mode. So savings of about 50%. Also looked into using <enhanced:img> but think this is a non-starter if we want to load different images based on CSS media queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the background images into wide and narrow variants so that we don't end up loading the full image where half of it will not be seen because of screen size.
The previous images were 384 KB for light mode, and 229 KB for dark mode. The new images are 145 KB / 166 KB for narrow/wide in light mode, and 83.8 KB / 104 KB for narrow/wide in dark mode. So savings of about 50%.
Also looked into using enhanced:img but think this is a non-starter if we want to load different images based on CSS media queries