Skip to content

Commit

Permalink
Use System.Text.Json in plugin over Newtonsoft (#665)
Browse files Browse the repository at this point in the history
Thinking about the build issue in #664 and how adding STJ fixed it
(still not sure why) I decided it's probably preferable to use STJ over
Newtonsoft, as then we can remove it from the solution.

Replaces Netwonsoft with STJ in the plugin. Retarget to net481 (latest
netfx release) after anecdotal evidence from Photon discord that this
works OK. This should fix most of our woes with packages not being
supported
  • Loading branch information
SapiensAnatis authored Feb 23, 2024
1 parent d29952b commit c53eddb
Show file tree
Hide file tree
Showing 13 changed files with 726 additions and 726 deletions.
3 changes: 1 addition & 2 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,11 @@
<PackageVersion Include="Respawn" Version="6.2.1" />
<PackageVersion Include="Snapshooter.Xunit" Version="0.14.1" />
<PackageVersion Include="Testcontainers" Version="3.7.0" />
<PackageVersion Include="Testcontainers.PostgreSql" Version="3.6.0" />
<PackageVersion Include="Testcontainers.PostgreSql" Version="3.7.0" />
<PackageVersion Include="Microsoft.Extensions.Identity.Core" Version="8.0.1" />
<PackageVersion Include="Moq.EntityFrameworkCore" Version="8.0.1.2" />
<PackageVersion Include="NSubstitute" Version="5.1.0" />
<PackageVersion Include="NSubstitute.Analyzers.CSharp" Version="1.0.17" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="Redis.OM" Version="0.6.1" />
<PackageVersion Include="Microsoft.AspNetCore.OpenApi" Version="8.0.1" />
<PackageVersion Include="Swashbuckle.AspNetCore" Version="6.5.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
<Folder Include="Features\Dmode\"/>
<Folder Include="Features\Item\"/>
<Folder Include="Features\Shop\"/>
<Folder Include="Other\__snapshots__\"/>
</ItemGroup>


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ public async Task HeroParam_ReturnsData()
.Should()
.AllSatisfy(x =>
{
x.editSkillcharacterId1.Should().Be(0);
x.editSkillcharacterId2.Should().Be(0);
x.editSkillLv1.Should().Be(0);
x.editSkillLv2.Should().Be(0);
x.EditSkillcharacterId1.Should().Be(0);
x.EditSkillcharacterId2.Should().Be(0);
x.EditSkillLv1.Should().Be(0);
x.EditSkillLv2.Should().Be(0);
});
}
}
Loading

0 comments on commit c53eddb

Please sign in to comment.