changes

.editorconfig

@@ -231,6 +231,9 @@ csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimenta
 dotnet_diagnostic.RMG012.severity = error # Unmapped target member
 dotnet_diagnostic.RMG020.severity = error # Unmapped source member
 
+# BannedApiAnalyzers
+dotnet_diagnostic.RS0030.severity = error # Banned symbol
+
 [DragaliaAPI/DragaliaAPI.Database/Migrations/*.cs]
 generated_code = true
 

Directory.Packages.props

@@ -22,6 +22,7 @@
     <PackageVersion Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.8" />
     <PackageVersion Include="Microsoft.AspNetCore.DataProtection.EntityFrameworkCore" Version="8.0.8" />
     <PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="8.0.8" />
+    <PackageVersion Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.4" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Features" Version="4.11.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.11.0" />

DragaliaAPI/DragaliaAPI.Database/Entities/DbTimeAttackClear.cs

@@ -24,5 +24,6 @@ public class DbTimeAttackClear
     /// Used to only allow 1 displayed leaderboard entry per set of players.
     /// </remarks>
     [NotMapped]
-    public int PlayersHash => 1;
+    public int PlayersHash =>
+        string.Join(string.Empty, this.Players.Select(x => x.ViewerId).Order()).GetHashCode();
 }

DragaliaAPI/DragaliaAPI.Database/Entities/DbTimeAttackPlayer.cs

@@ -1,6 +1,5 @@
 using System.ComponentModel.DataAnnotations;
 using System.ComponentModel.DataAnnotations.Schema;
-using System.Text.Json;
 using Microsoft.EntityFrameworkCore;
 
 namespace DragaliaAPI.Database.Entities;

DragaliaAPI/DragaliaAPI/BannedSymbols.txt

@@ -0,0 +1 @@
+T:LinqToDB.AsyncExtensions;Don't use Linq2DB methods that conflict with Entity Framework, use e.g. ToListAsyncLinq2DB instead.

DragaliaAPI/DragaliaAPI/DragaliaAPI.csproj

@@ -26,6 +26,10 @@
       <IncludeAssets>build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
     <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" />
+    <PackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
     <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" />
     <PackageReference Include="Microsoft.Extensions.Caching.StackExchangeRedis" />
@@ -74,6 +78,10 @@
     <Using Include="DragaliaAPI.Extensions" />
   </ItemGroup>
 
+  <ItemGroup>
+    <AdditionalFiles Include="BannedSymbols.txt" />
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\DragaliaAPI.Database\DragaliaAPI.Database.csproj" />
     <ProjectReference Include="..\..\Shared\DragaliaAPI.Photon.Shared\DragaliaAPI.Photon.Shared.csproj" />

DragaliaAPI/DragaliaAPI/Infrastructure/Linq2Db/Json.cs

@@ -5,9 +5,15 @@
 
 namespace DragaliaAPI.Infrastructure.Linq2Db;
 
+/// <summary>
+/// Helper class for using JSON columns with Linq2DB.
+/// </summary>
+/// <remarks>
+/// Adapted from https://github.com/linq2db/linq2db/issues/4343#issuecomment-1816460380
+/// </remarks>
 internal static class Json
 {
-    sealed class JsonValuePathBuilder : Sql.IExtensionCallBuilder
+    private sealed class JsonValuePathBuilder : Sql.IExtensionCallBuilder
     {
         public void Build(Sql.ISqExtensionBuilder builder)
         {
@@ -42,6 +48,12 @@ public void Build(Sql.ISqExtensionBuilder builder)
         }
     }
 
+    /// <summary>
+    /// Access the JSON object property named by <paramref name="name"/> inside the JSON column <paramref name="prop" />
+    /// </summary>
+    /// <param name="prop">The JSON column to index.</param>
+    /// <param name="name">The property name of the object to access.</param>
+    /// <returns>The indexed value.</returns>
     [Sql.Extension(
         ProviderName.PostgreSQL,
         Precedence = Precedence.Primary,

Website/tests/timeAttack.test.ts

@@ -48,6 +48,8 @@ test('clicking icons shows info popovers', async ({ page }) => {
 
   await waitForImagesToLoad(page);
 
+  await page.waitForTimeout(500); // ???
+
   const topRow = page.getByRole('row', { name: /1 Qwerby/ });
 
   await topRow.getByRole('button', { name: 'Expand character details' }).first().click();