NULL repeated fields should be converted to an empty list #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the 'JSON Mapping' section in the proto3 Language guide found here: https://developers.google.com/protocol-buffers/docs/proto3#json It is mentioned that NULL repeated fields should be converted to an empty list. Currently protobuf2json-c does not convert a NULL repeated field to JSON (it simply ignores it). This patch updates the library to ensure that NULL repeated fields are converted to empty JSON lists.
This was referenced Oct 13, 2019
Open
|
Travis CI is failing due to libjansson missing on the build server (unrelated to this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the 'JSON Mapping' section in the proto3 Language guide
found here:
https://developers.google.com/protocol-buffers/docs/proto3#json
It is mentioned that NULL repeated fields should be converted to an
empty list.
Currently protobuf2json-c does not convert a NULL repeated field to
JSON (it simply ignores it). This patch updates the library to ensure
that NULL repeated fields are converted to empty JSON lists.