Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge topic/teams into master #906

Merged
merged 101 commits into from
Nov 19, 2019
Merged

Merge topic/teams into master #906

merged 101 commits into from
Nov 19, 2019

Conversation

jdinan
Copy link
Member

@jdinan jdinan commented Nov 19, 2019

No description provided.

davidozog and others added 30 commits April 12, 2019 17:44
@davidozog
Add Teams bare-bones API without any functionality
6d3a31b 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Add a KVS of available teams (DO NOT MERGE)
73439c9 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Teams: remove uthash and make all strides linear
99d2f97 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Add shmemx_tem_translate unit test
f00ac33 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Fix global_exit seg fault with no backtrace method
1526cf2 
Signed-off-by: David Ozog <[email protected]>
@davidozog
Return #include "config.h" to shmem_env.h
2f2fb84 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Assure teams API routines are prepended w/ shmemx
52339d8 
Signed-off-by: David Ozog <[email protected]>
@davidozog
Add implementation/test of shmem_team_translate_pe
0e9a662 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Update to shmem_internal_team_t where needed
1b53db4 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Implement shmemx_team_split_2D and add a unit test
81884da 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Cleanup team split code, remove post-split barrier
23226ca 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Add shmemx_sync/shmemx_team_sync with unit test
8e4f844 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Implement shmemx_broadcast with teams support
41feee7 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Add teams collect, fcollect, alltoall, alltoalls
e587b63 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Add bindings for collectives, fix c11 shmemx tests
3332081 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Cleanup the shmemx tests, don't exit(0) on failure
b01b801 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Point contexts to the appropriate team, add test
18becf8 
Signed-off-by: David Ozog <[email protected]>
@davidozog
Add team PE indexing for ctx RMA/AMO operations
b7fd4fa 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Add C++/C11 teams API bindings and set psync bits
1ef41d7 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Rename some vars and fix destroy & op_to_all bugs
4c8fa5c 
Signed-off-by: David Ozog <[email protected]>
@davidozog
Add team field to portals and none transport ctxs
8c73f23 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Support reduce_local unsigned types, fix example
1598f51 
Signed-off-by: David Ozog <[email protected]>
@davidozog
Use separate psync in non-barrier/sync collectives
4a1391c 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Add preliminary support for SHMEMX_TEAM_SHARED
568324b 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Rewrite TEAM_SHARED stride check without a malloc
00bac21 
Signed-off-by: David Ozog <[email protected]>
@davidozog
Fix pWrk mistake, rename a variable in team init
2665b71 
Signed-off-by: David Ozog <[email protected]>
@davidozog
Simplify search for local peer PEs in TEAM_SHARED
63cfde3 
Signed-off-by: David Ozog <[email protected]>
@davidozog
Merge branch 'master' of github.com:davidozog/sandia-shmem into wip/t…
de5ba2c 
…eams
@davidozog
Cleaning pre-defined teams initialization
a4f0217 
Signed-off-by: David Ozog <[email protected]>
@davidozog
Cleanup teams c11/cxx bindings and SHMEMX_* fixes
41109d2 
Signed-off-by: David M. Ozog <[email protected]>
James Dinan and others added 28 commits November 15, 2019 14:23
Remove extra team dup in collect active set test
88f46fe 
Signed-off-by: James Dinan <[email protected]>
Mark internal function static
fce3cb2 
Should not be necessary to declare functions that are static.

Signed-off-by: James Dinan <[email protected]>
Update C11 test macro to eat the semicolon
be9f86a 
Signed-off-by: James Dinan <[email protected]>
Update choose_psync to return long*
f8b9ff6 
Signed-off-by: James Dinan <[email protected]>
Move accessors up to user bindings
aa8bd2f 
These functions are short and aren't needed in the internal API, so our
convention has been to put the implementation directly into the
bindings layer.  Caught a few missing checks for invalid handles in the
process.

Signed-off-by: James Dinan <[email protected]>
Update to make unit test work with c99 compilers
87a44ea 
Signed-off-by: James Dinan <[email protected]>
Fix choose_psync comment
9e2e095 
Signed-off-by: James Dinan <[email protected]>
@davidozog
Merge pull request #7 from jdinan/wip/teams
a296326 
Teams Unit Test Updates from Code Review
Use persistent assertion in team init
314daa8 
Signed-off-by: James Dinan <[email protected]>
Remove dead code from team init
39c3694 
Signed-off-by: James Dinan <[email protected]>
Set team world on the default context
1cc7b7e 
Signed-off-by: James Dinan <[email protected]>
Improve error message
db112f5 
Signed-off-by: James Dinan <[email protected]>
@davidozog
Various teams review, round #4.
daff427 
* README update
* teams_fini reordering
* shmem_internal_free moved
* added shmem_internal_bit_fetch
* rename/comment check_for_linear_stride
* move teams_init errors to appropriate place
* move teams_init pool initializations to appropriate place
* use shmem_internal_params.TEAMS_MAX
* use asserts where needed
* fix 'myteam' leak in parent-only PEs
* fix choose_psync bug for parent-only PEs
* more informative error in split_strided
* All of parent must call split_strided in split_2d
* cleanup unit tests
* other minor changes...

Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Merge pull request #8 from jdinan/wip/teams
9044877 
Fixes to wip/teams
@davidozog
Merge branch 'wip/teams' of github.com:davidozog/sandia-shmem into wi…
595d1f0 
…p/teams
@davidozog
Destroy the predefined teams in shmem_team_fini
57d414b 
Signed-off-by: David M. Ozog <[email protected]>
@davidozog
Destroy predefined teams outside portals as well
7c57f6f 
Signed-off-by: David M. Ozog <[email protected]>
Remove redundant PE id from error message
d40b74b 
Signed-off-by: James Dinan <[email protected]>
Improve error handling for SHMEM_TEAMS_MAX
1d2da2b 
Catch and correct for SHMEM_TEAMS_MAX values that are too small.

Signed-off-by: James Dinan <[email protected]>
Only set bits corresponding to allocated psyncs
b4e26ca 
Signed-off-by: James Dinan <[email protected]>
Add psync avail bit string debugging output
3b85c1a 
Signed-off-by: James Dinan <[email protected]>
Add comment about SHMEM_CTX_DEFAULT destroy
24ca0a0 
This is a special case; the default context isn't inserted into the
contexts list on the world team, so it is not freed when the teams are
destroyed.  This context must be freed separately by the transport
layer.

Signed-off-by: James Dinan <[email protected]>
Remove sketchy spec tests
90886c8 
These tests are failing and it looks like there may be bugs in the unit
tests.  Setting these tests aside for debugging.

Signed-off-by: James Dinan <[email protected]>
Set my_pe field on new teams
c76260f 
Signed-off-by: James Dinan <[email protected]>
Fix bugs in spec tests
0310b31 
Signed-off-by: James Dinan <[email protected]>
Update reductions to support size_t nreduce
5294eb0 
Signed-off-by: James Dinan <[email protected]>
@davidozog
Merge pull request #886 from davidozog/wip/teams
788ad10 
Teams API topic branch
@jdinan
Merge branch 'master' into topic/teams
cf7beea
@jdinan
Copy link
Member Author

jdinan commented Nov 19, 2019

@davidozog #886 when into topic/teams. This PR will merge topic/teams into master.

@jdinan jdinan merged commit 9c22e2e into master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdinan @davidozog