Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

fix: Fix buffer overflow #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

howjmay
Copy link

@howjmay howjmay commented Jan 14, 2020

If we write the 1024th element on an array whose
length is 1024, it will cause buffer overflow.

@LaszloLango
Copy link
Contributor

@howjmay Thank you for your contribution. Please add the missing sign-off statement to the end of the commit message. (Check the CI log for more details of the failure: https://travis-ci.org/Samsung/libtuv/jobs/636707515?utm_medium=notification&utm_source=github_status)

Signed-off-by message is incorrect. The following line should be at the end of the 6accce7 commit's message: 'libtuv-DCO-1.0-Signed-off-by: YangHau [email protected]'.

@howjmay
Copy link
Author

howjmay commented Jan 24, 2020

I have signed it

@LaszloLango
Copy link
Contributor

CI still fails because of the wrong sign-off

If we write the 1024th element on an array whose
length is 1024, it will cause buffer overflow.

Signed-off-by: HowJMay <[email protected]>
@howjmay
Copy link
Author

howjmay commented Jan 24, 2020

Sorry I got some problem when signing my commit.
I used command git commit --amend -s
Did I do something wrong?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants