apply ValuePemPatternCheck for PEM rule #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babenek
force-pushed
the
jwt
branch
2 times, most recently
from
5c6c7fc
to
a50a938
Compare
csh519
reviewed
Jun 26, 2023
csh519
reviewed
Jun 26, 2023
| @@ -58,15 +60,12 @@ def is_pem_key(cls, lines: List[str], config: Config) -> bool: | |||
| lines = cls.strip_lines(lines) | |||
| lines = cls.remove_leading_config_lines(lines) | |||
There was a problem hiding this comment.
About checking line length is over 190 or not, this method remove_leading_config_lines() can reduce size of lines.
So isn't it good to just remain line length check code here?
Like below.
Comment on lines
61
to
63
| for line_num, line in enumerate(lines): | ||
| if line_num >= 190: | ||
| return False |
There was a problem hiding this comment.
if len(lines) >= 190:
return FalseThere was a problem hiding this comment.
Opposite. It will skip huge files.
```remove_leading_config_lines`` does not trim ending so there might be a long tail over 190 lines with remaining.
If the key will be not found in given 190 lines - it returns False at end of function.
|
Closing due many conflicts. All the changes will be in #373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
REVIEW AFTER #370 !!!
Please include a summary of the change and which is fixed.
How has this been tested?
Please describe the tests that you ran to verify your changes.