Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 3.12 #77

Merged
merged 19 commits into from
Apr 19, 2024
Merged

Update to Python 3.12 #77

merged 19 commits into from
Apr 19, 2024

Conversation

douglatornell
Copy link
Member

@douglatornell douglatornell commented Apr 19, 2024

  • Add Python 3.12 to GHA pytest-with-coverage workflow so that we can use the workflow to test whether all the packages NEMO-Cmd depends on have been updated to support Python 3.12.
  • Add workflow_dispatch trigger to GHA pytest-with-coverage workflow to enable workflow to be triggered from
    GitHub CLI, browser or via API
  • Drop Python 3.10 & 3.11 from GHA pytest-with-coverage workflow
  • Change setup.cfg python_requires to >=3.12
  • Change conda environment descriptions to use Python 3.12
    • environment-dev.yaml
    • environment-prod.yaml
    • environment-rtd.yaml
  • Change sphinx-linkcheck workflow to Python 3.12
  • Change index doc & README to Python 3.12 for package development

This lets us use the workflow to test whether all the packages NEMO-Cmd depends
on have been updated to support Python 3.12.
Enables workflow to be triggered from GitHub CLI, browser, or via API.

This is primarily to allow the workflow to be run via
    gh workflow run pytest-with-coverage --ref py312
during the conda-forge Python 3.12 migration to test if the environment is
solvable yet.
As recommended for reproducible builds on readthedocs:
https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html
and to ensure that our docs build works with readthedocs changes to default
project dependencies:
https://blog.readthedocs.com/defaulting-latest-build-tools/
@douglatornell douglatornell added the maintenance Codebase & repo maintenance label Apr 19, 2024
@douglatornell douglatornell added this to the v24.1 milestone Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (7e7aae8) to head (ac2aa71).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   74.83%   74.83%           
=======================================
  Files          14       14           
  Lines         906      906           
  Branches       87      161   +74     
=======================================
  Hits          678      678           
  Misses        221      221           
  Partials        7        7           
Flag Coverage Δ
unittests 74.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This lets us use the workflow to test whether all the packages NEMO-Cmd depends
on have been updated to support Python 3.12.
Enables workflow to be triggered from GitHub CLI, browser, or via API.

This is primarily to allow the workflow to be run via
    gh workflow run pytest-with-coverage --ref py312
during the conda-forge Python 3.12 migration to test if the environment is
solvable yet.
They are now just outdated maintenance overhead.
Python version used in Sphinx Linkcheck GitHub Actions workflow has been updated
from 3.10 to 3.12.
Drop support and testing coverage for Python 3.10 to 3.11.
@douglatornell douglatornell merged commit e5e7b6b into main Apr 19, 2024
8 checks passed
@douglatornell douglatornell deleted the py312-redux branch April 20, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Codebase & repo maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant