-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Python 3.12 #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us use the workflow to test whether all the packages NEMO-Cmd depends on have been updated to support Python 3.12.
Enables workflow to be triggered from GitHub CLI, browser, or via API. This is primarily to allow the workflow to be run via gh workflow run pytest-with-coverage --ref py312 during the conda-forge Python 3.12 migration to test if the environment is solvable yet.
As recommended for reproducible builds on readthedocs: https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html and to ensure that our docs build works with readthedocs changes to default project dependencies: https://blog.readthedocs.com/defaulting-latest-build-tools/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 74.83% 74.83%
=======================================
Files 14 14
Lines 906 906
Branches 87 161 +74
=======================================
Hits 678 678
Misses 221 221
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This lets us use the workflow to test whether all the packages NEMO-Cmd depends on have been updated to support Python 3.12.
Enables workflow to be triggered from GitHub CLI, browser, or via API. This is primarily to allow the workflow to be run via gh workflow run pytest-with-coverage --ref py312 during the conda-forge Python 3.12 migration to test if the environment is solvable yet.
They are now just outdated maintenance overhead.
Python version used in Sphinx Linkcheck GitHub Actions workflow has been updated from 3.10 to 3.12.
Drop support and testing coverage for Python 3.10 to 3.11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow_dispatch
trigger to GHA pytest-with-coverage workflow to enable workflow to be triggered fromGitHub CLI, browser or via API
setup.cfg python_requires
to >=3.12environment-dev.yaml
environment-prod.yaml
environment-rtd.yaml