Ensure all aeon submodules included in wheel #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbhagatio
reviewed
Jul 3, 2024
glopesdev
force-pushed
the
gl-issue-375
branch
from
5f64e90
to
893cb2d
Compare
jkbhagatio
approved these changes
Aug 15, 2024
glopesdev
force-pushed
the
gl-issue-375
branch
from
893cb2d
to
4139bd5
Compare
lochhh
approved these changes
Aug 15, 2024
glopesdev
force-pushed
the
gl-issue-375
branch
from
4139bd5
to
94b972c
Compare
glopesdev
force-pushed
the
gl-issue-375
branch
from
94b972c
to
4196b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the package discovery docs for setuptools each submodule needs to be either explicitly added, or the
findfeature should be used to automatically discover all relevant packages.This PR replaces the
setuptoolsdeclaration inpyproject.tomlto automatically include all submodules inside theaeonfolder when building the wheel, e.g. when installing the repo frompipin non-editable mode.We can consider whether we want to further split the package into different sub-wheels or features for the datajoint pipeline, or other optional functionality, but this can be done in a separate discussion / PR.
Fixes #375