Downgrade to Java 11, fix missed test failure

Sage-Bionetworks · Aug 28, 2024 · fc39d67 · fc39d67
1 parent cfd2413
commit fc39d67
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/build/action.yml b/.github/workflows/build/action.yml
@@ -3,10 +3,10 @@ description: 'Build SWC'
 runs:
   using: 'composite'
   steps:
-    - name: Set up JDK 17
+    - name: Set up JDK 11
       uses: actions/setup-java@v4
       with:
-        java-version: '17'
+        java-version: '11'
         distribution: 'corretto'
         cache: maven
     - name: Build with Maven

diff --git a/pom.xml b/pom.xml
@@ -13,8 +13,8 @@
 
   <properties>
     <!-- Synapse Web Client -->
-    <maven.compiler.source>17</maven.compiler.source>
-    <maven.compiler.target>17</maven.compiler.target>
+    <maven.compiler.source>11</maven.compiler.source>
+    <maven.compiler.target>11</maven.compiler.target>
     <webappDirectory>
       ${project.build.directory}/${project.build.finalName}
     </webappDirectory>

diff --git a/src/test/java/org/sagebionetworks/web/unitserver/servlet/AliasRedirectorServletTest.java b/src/test/java/org/sagebionetworks/web/unitserver/servlet/AliasRedirectorServletTest.java
@@ -2,6 +2,7 @@
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Matchers.anyList;
 import static org.mockito.Matchers.anyString;
 import static org.mockito.Matchers.eq;
@@ -63,8 +64,7 @@ public void setup()
     throws IOException, SynapseException, JSONObjectAdapterException {
     MockitoAnnotations.initMocks(this);
     servlet = new AliasRedirectorServlet();
-    when(mockSynapseProvider.createNewClient(anyString()))
-      .thenReturn(mockSynapse);
+    when(mockSynapseProvider.createNewClient(any())).thenReturn(mockSynapse);
 
     servlet.setSynapseProvider(mockSynapseProvider);
 
@@ -148,8 +148,9 @@ public void testDoGetTeamAlias() throws Exception {
   @Test
   public void testDoGetError() throws Exception {
     String errorMessage = "An error from the service call";
-    when(mockSynapse.getUserGroupHeadersByAliases(anyList()))
+    when(mockSynapse.getUserGroupHeadersByAliases(any()))
       .thenThrow(new SynapseForbiddenException(errorMessage));
+
     servlet.doGet(mockRequest, mockResponse);
 
     // redirects to an error place