Do not generate docker configuration on pubcloud #270
Conversation
mssola
force-pushed
the
suseconnect-do-not-generate-docker-on-pubcloud
branch
from
b1827de
to
86a79cd
Compare
mssola
force-pushed
the
suseconnect-do-not-generate-docker-on-pubcloud
branch
from
86a79cd
to
78c1112
Compare
There was a problem hiding this comment.
lgtm 👍
How I reviewed this merge request:
- Checked the code changes to suggest improvements
- Built connect and ran against a RMT and SCC to checked that the credentials are set accordingly
As always, if you think I missed something, I should look into, please let me know!🚀
cheers,
mssola
force-pushed
the
suseconnect-do-not-generate-docker-on-pubcloud
branch
from
c1461c7
to
d13d099
Compare
This allows the internal configuration of SUSEConnect to understand on which kind of server it's trying to connect. This is relevant in case we want to perform some operations on SCC and some others on RMT. Signed-off-by: Miquel Sabaté Solà <[email protected]>
Fixes bsc#1231185 Signed-off-by: Miquel Sabaté Solà <[email protected]>
mssola
force-pushed
the
suseconnect-do-not-generate-docker-on-pubcloud
branch
from
d13d099
to
77d734f
Compare
|
@felixsch check again. Now tests are passing. Note that I have added a couple of other paths in which to double check the "server type". I have tested it locally and it appears to work, but double check just to be sure 😉 |
Nice will do. Do you mind adding it to labels as well? Then I do not need to do another PR :) |
Signed-off-by: Miquel Sabaté Solà <[email protected]>
There was a problem hiding this comment.
lgtm 👍
How I reviewed this merge request:
- Checked the code changes and see it working when:
- Running against SCC and check if the file is placed and labels are set
- Running against RMT and check that the file is not placed and labels are not sent
- Checked the changes and added improvements if I think they would make sense
As always, if you think I missed something I should test please let me know!🚀
cheers,
Fixes bsc#1231185
How to test
If you use SUSEConnect on Glue, the configuration should happen, otherwise it won't be generated.