Noinline fix #67
Merged
Noinline fix #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to check for more stuff in PrettyPrint. Signed-off-by: Giuliano Belinassi <[email protected]>
In kernel sourcecode there is a definition of a macro: ``` ``` This seems harmless, but when clang-extract decides to dump the AST of a Decl, this conflicts with its attr: ``` __attribute__((noinline)) ``` which results in the resulting code being broken. Hence, undefine this macro for the AST dump and define it later. Signed-off-by: Giuliano Belinassi <[email protected]>
giulianobelinassi
force-pushed
the
noinline_fix
branch
from
173069a
to
aff6d64
Compare
|
That's good, and another fix to the linux kernel! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undefine noinline macro if conflicts with AST dump
In kernel sourcecode there is a definition of a macro:
This seems harmless, but when clang-extract decides to dump the AST of
a Decl, this conflicts with its attr:
which results in the resulting code being broken. Hence, undefine this
macro for the AST dump and define it later.
Closes #15
Signed-off-by: Giuliano Belinassi [email protected]