SymbolExternalizer: Rename externalized operand of sizeof #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulianobelinassi
requested changes
Jun 14, 2024
libcextract/SymbolExternalizer.cpp
Outdated
| * } | ||
| */ | ||
| DeclStmt *dstmt = (DeclStmt *) stmt; | ||
| Decl *ddecl = dstmt->getSingleDecl(); |
There was a problem hiding this comment.
Perhaps we should do an assertion here to check if the type of this Decl is an array of some sort by using ddecl->getType()->isArrayType() just to be sure that we are not overwriting something we shouldn't.
libcextract/SymbolExternalizer.cpp
Outdated
| auto vec_of_ranges = Get_Range_Of_Identifier_In_SrcRange(ddecl->getSourceRange(), | ||
| OldSymbolName.c_str()); | ||
|
|
||
| if (vec_of_ranges.size() > 0) { |
There was a problem hiding this comment.
We may iterate on all elements of vec_of_ranges because we can have things like char y[sizeof(x)][sizeof(x)].
testsuite/ccp/ext5-obj-5.c
Outdated
|
|
||
| void pu_f(void) | ||
| { | ||
| char s[sizeof(ee_o)]; |
There was a problem hiding this comment.
can you also add two checks:
char t[sizeof(ee_o)][sizeof(ee_o)];- The new sizeof matches the sizeof with the old declaration. You can do that by declaring an auxiliary array:
char v[sizeof(x) - 4]for example. Any array size >= 0 will be accepted by the compiler and thus you can implement anstatic_assertwith it. Or perhaps just do straight_Static_assert().
|
I added static_assert and checked for x[sizeof(y)][sizeof(y)], and it worked. The only thing that was not working was the assert for the arrayType. |
|
Added an issue in llvm about the fact that |
Signed-off-by: Marcos Paulo de Souza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.