Check agent liveness while migrating #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuntz
approved these changes
May 15, 2017
files/default/neutron-ha-tool.py
Outdated
| errors += 1 | ||
| if fail_fast: | ||
| break | ||
| elif migration_result.skipped: | ||
| return (migrations, errors) |
There was a problem hiding this comment.
Does it make sense to log something here?
added 7 commits
May 15, 2017 15:11
Given that now we have multiple scripts, it makes sense to introduce a test runner. nosetests seems to support our weird file namings, so using that. It picked up signal_tester as a testcase, so that has been renamed. Also amended travis, and added noqa for some flake8 violations. (cherry picked from commit b1d6f84)
Checking the agent liveness and migrating the agents are two separate calls of neutron-ha-tool. It does not make sense to print out what would be the target agent on checking, because: - the choice is random - the router distribution might change between two calls Therefore removing the misleading statements, and just listing routers to be migrated.
Add some unit tests to cover existing functionality of that method.
`migrate_router_safely` method returned a boolean that indicated the success of the migration. Given that we want to put a check on agent liveness to the method, it will be possible that the migration will be skipped if the agent is alive, thus the return value needs to represent that fact as well. By making the method return an object, multiple return values can be added.
When migrating routers away, make sure that the migration is skipped if the agent is already back on it's feet.
When we skipped migrating a router, that means that the agent has came back alive, so there is no need to call the migration for the rest of the routers on that specific agent.
This makes it easier to understand what the tool did, especially in the case when the agent became online in the meanwhile.
|
Re-basing and adding the change... |
|
@vuntz Added a separate commit for adding the log messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that agent liveness is checked before migrating a router in
l3-agent-migratemode.Please note that the first commit is part of another PR (#30) as well (a small cleanup commit)