Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates for dualstack (ipv4/ipv6) control plane #3446

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

templates for dualstack (ipv4/ipv6) control plane #3446

wants to merge 4 commits into from
+496 −8

Conversation

spacefito
Copy link
Contributor

Contains templates for dualstack
Allows for disabling firewall
Adds scripts to generate input model but not deploy to ecp

@spacefito spacefito added the wip label May 22, 2019
italiahardik
italiahardik suggested changes May 23, 2019
View reviewed changes
Copy link
Contributor

@italiahardik italiahardik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dualstack support is already there but with this change, it seems we are trying to run mysql & rabbitmq services on ipv4. If so, update the commit message with details will be helpful.

scripts/jenkins/ardana/manual/input.yml.example Show resolved Hide resolved
...ins/ardana/ansible/roles/input_model_generator/templates/input_model/data/network_groups.yml Show resolved Hide resolved
Adolfo Duarte and others added 2 commits May 23, 2019 16:44
default endpoints only in ipv6 management
546292b 
when ipv6 is being used for management
all services should be place in that network
by default. They should not be placed in the
ipv4 network.
no route to other networks from ipv4 management
2ac1fe9
@spacefito spacefito removed the wip label Jun 4, 2019
nicolasbock
nicolasbock suggested changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the example input file!

...ins/ardana/ansible/roles/input_model_generator/templates/input_model/data/network_groups.yml Show resolved Hide resolved
@spacefito spacefito closed this Jun 14, 2019
@spacefito
Copy link
Contributor Author

closed by mistake

@spacefito spacefito reopened this Jun 14, 2019
@spacefito spacefito added the wip label Jun 14, 2019
@spacefito
Copy link
Contributor Author

Making this a WIP again, there is too much changes to the input model templates.
I don't feel confortable at this point. We need to make sure we dont' break other stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmwiedemann bmwiedemann bmwiedemann left review comments

@nicolasbock nicolasbock nicolasbock requested changes

@italiahardik italiahardik italiahardik requested changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@spacefito spacefito

Labels
IPv6-CP wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spacefito @bmwiedemann @nicolasbock @italiahardik