Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

designate: create a test port and nslookup it #3443

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −2
Open

designate: create a test port and nslookup it #3443

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
886d865
designate: create a test port and nslookup it
May 17, 2019
1b2e4cc
designate: add tld as expected by designate-tempest-plugin (SOC-9342)
May 31, 2019
067ac7e
Update scripts/qa_crowbarsetup.sh
sjamgade Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions scripts/qa_crowbarsetup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4116,8 +4116,17 @@ function oncontroller_testsetup
fi

# this file is created by the designate barclamp
designate_pools="/etc/desigate/pools.crowbar.yaml"
[[ -e $designate_pools ]] && designate-manage pool update --file $designate_pools
designate_pools="/etc/designate/pools.crowbar.yaml"
if [[ -e $designate_pools ]]; then
designate-manage pool update --file $designate_pools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be already done by the barclamp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the barclamp leaves a sample pool file /etc/designate/pools.crowbar.yaml" for the admin to review.

Why the barclamp doesnot do this ?
The way designate is currently installed, a zone will be created as soon as a vm is created, the only thing stopping it is "unavailability" of pool in designate. This will have security implication (allowing anyone who can create a vm to create a zone, leaking dns zone information on un-intended network, causing conflicts in dns resolution).

However this is needed to test designate, so adding it here as part of automation.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being taken care of by crowbar/crowbar-openstack#2192

# default values from the node.neutron.dns_domain
openstack tld create --name local
openstack zone create --email [email protected] openstack.local.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be done by the neutron integration of the barclamp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without pools, designate cannot create zones, (so they can be XFRd to be resolvable)

theport=$(openstack port create --network fixed --dns-name iamgroot thanos -f value -c id)
openstack floating ip create floating --port $theport
wait_for 30 5 "nslookup iamgroot.openstack.local >> /dev/null" "thanos port is nslookup-able"
[ $want_tempest = 1 ] && openstack tld create --name com # needed by designate-template-plugin smoke test
sjamgade marked this conversation as resolved.
Show resolved Hide resolved
fi

# Run Tempest Smoketests if configured to do so
tempestret=0
Expand Down