Feature.authorization rbac #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
I thought I tested it well enough yesterday, but today with working on the frontend I ran into bugs logging in. So we are getting the algorithm from the header again.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #326 +/- ##
===========================================
- Coverage 65.06% 64.66% -0.41%
===========================================
Files 70 69 -1
Lines 7823 7624 -199
===========================================
- Hits 5090 4930 -160
+ Misses 2733 2694 -39 ☔ View full report in Codecov by Sentry. |
src/cnaas_nms/app_settings.py
Outdated
| CAFILE: Optional[Path] = "/opt/cnaas/cacert/rootCA.crt" | ||
| CAKEYFILE: Path = "/opt/cnaas/cacert/rootCA.key" | ||
| CERTPATH: Path = "/tmp/devicecerts/" | ||
| JWT_CERT: Path = Path("./opt/cnaas/jwtcert/public.pem") |
There was a problem hiding this comment.
The path here has an extra . at the beginning causing integration test errors
…nf, remove unneccersary lib
make sure to read permission_disabled setting from file before building default rules
…naas-nms into feature.authorization
…to help performance a bit with two connections to the same host
…ity server for every request. This makes the API a lot more responsive
…set/sent, to be used for the /auth/refresh endpoint
the callback as well Add /auth/refresh API endpoint to support using refresh_tokens
…e compatible with client_credentials type clients
…d of hardcoding to email
…urned, run dos2unix for fixing line endings
… be needed with multiprocess integrationtests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add permissions to the authentication so different user roles can have different permissions