Rewrite log.py #238
Rewrite log.py #238
Conversation
move logging init into its own function. Change how get_logger works. Logging now uses one logger (in additon to flask logger)
Codecov ReportBase: 59.97% // Head: 59.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #238 +/- ##
===========================================
- Coverage 59.97% 59.73% -0.25%
===========================================
Files 62 62
Lines 6219 6221 +2
===========================================
- Hits 3730 3716 -14
- Misses 2489 2505 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Some merge conflict appeared here, but probably very minor one? |
|
SonarCloud Quality Gate failed.
|
PR for #237
move logging init into its own function. This has to be called for logging to work, but makes it possible for testing to just not call it and not require redis anymore.
Other changes to logging: Instead of creating new loggers for each job, the same logger is used for all loggers (and also the flask logger is available separately). This logger changes format based on if it is a job thread or not, so the logging format should be the same as previously, but less loggers are used.
From Flask documentation, logger should preferably be initialized before app object is made, so i added a call to the init function in app.py.