DS-576 | @ericbakenhus | Remove WYSIWYG empty links #408
Conversation
| @@ -12,6 +12,7 @@ function createMarkup(storyblokHTML) { | |||
| allowedTags: false, // This allows extra HTML tags to be rendered, e.g., H2, img | |||
| allowedAttributes: false, // This allows custom class names | |||
| allowVulnerableTags: true, // https://github.com/apostrophecms/sanitize-html/blob/main/CHANGELOG.md#1250 | |||
| exclusiveFilter: (frame) => frame.tag === 'a' && !frame.text.trim(), // Remove empty links | |||
There was a problem hiding this comment.
Removes empty links. The sanitize-html docs use removing empty links as their exclusiveFilter example: https://www.npmjs.com/package/sanitize-html#filters 😆
There was a problem hiding this comment.
@sherakama Unlike the related Alumni site fix, this will also remove links that have child elements (e.g. <br>) as long as there's no eventual text ancestors. That could cause some unexpected layout shifting.
I think I'm going to close this PR, manually handle the handful of WYSIWYG issues to get rid of the a11y issue, then handle this in the site rebuild instead...
There was a problem hiding this comment.
That sounds like a reasonable pivot to me.
You can put this into draft to keep it around for a bit if you'd like.
NOT READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
Associated Issues and/or People