📈 App Router - added app insights telemetry for app components #3151

Calinator444 · 2024-09-23T04:38:17Z

Description

This PR adds app insights telemetry to all existing App Router pages. Because the code has been added to layout.tsx the telemetry should be sent from all future pages to use app routing as well.

Affected routes:
Fixed ✨ App Routing - 📈Add telemetry for app router pages #3153

github-actions · 2024-09-23T04:39:20Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	0.22%	69/31231
🔴	Branches	7.55%	24/318
🔴	Functions	1.01%	3/297
🔴	Lines	0.22%	69/31231

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from e0e3e58

github-actions · 2024-09-23T05:15:37Z

Deployed changes to https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

github-actions · 2024-09-23T05:17:36Z

PageSpeed Insights

Category	Score
Accessibility	95
Best practices	96
Performance	65
SEO	69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

Calinator444 · 2024-09-23T05:40:47Z

No longer relevant - I've made changes following these tests

I have the requests being logged to app insights in staging

github-actions · 2024-09-23T06:03:57Z

Deployed changes to https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

github-actions · 2024-09-23T06:04:39Z

PageSpeed Insights

Category	Score
Accessibility	95
Best practices	96
Performance	64
SEO	69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

amankumarrr · 2024-09-23T07:36:58Z

We should avoid using <Suspense> to wrap this component. Ideally, it should be a server-side component. Telemetry and App Insights should only wrap the child components. Perhaps we can try using template.ts for client-side rendering, which might allow us to send telemetry from the client-side.

amankumarrr · 2024-09-23T07:42:05Z

maybe something like this:

"use client";
import { AppInsightsProvider } from "@/context/app-insight-client";
import { TelemetryProvider } from "./components/TelemetryProvider";

export default function Template({ children }: { children: React.ReactNode }) {
  return (
    <AppInsightsProvider>
      <TelemetryProvider>{children}</TelemetryProvider>
    </AppInsightsProvider>
  );
}

…ider

github-actions · 2024-09-24T04:37:29Z

Deployed changes to https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

github-actions · 2024-09-24T04:38:14Z

PageSpeed Insights

Category	Score
Accessibility	95
Best practices	96
Performance	64
SEO	69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

github-actions · 2024-09-24T05:32:35Z

Deployed changes to https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

github-actions · 2024-09-24T05:33:17Z

PageSpeed Insights

Category	Score
Accessibility	95
Best practices	96
Performance	63
SEO	69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

github-actions · 2024-09-24T05:55:01Z

Deployed changes to https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

github-actions · 2024-09-24T05:55:43Z

PageSpeed Insights

Category	Score
Accessibility	95
Best practices	96
Performance	65
SEO	69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

amankumarrr · 2024-09-24T06:09:50Z

WebVitals are being logged correctly!

amankumarrr · 2024-09-24T23:52:32Z

Note: The red arrow denotes the point in time when the page was migrated to app routing

Figure: Page views over time for /products

amankumarrr · 2024-09-25T00:04:47Z

Tested with upcoming UG, seems to be working fine!

github-actions · 2024-09-25T00:10:18Z

Deployed changes to https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

github-actions · 2024-09-25T00:11:05Z

PageSpeed Insights

Category	Score
Accessibility	95
Best practices	96
Performance	66
SEO	69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

Calinator444 · 2024-09-25T00:24:29Z

Worried about the missing Suspense boundary around the LiveStream component but Aman has confirmed with me that this issue does not result in errors when building the website locally.

Calinator444 · 2024-09-25T00:38:18Z

@wicksipedia @bradystroud

I tested this to ensure it was sending requests to app insights in staging.

github-actions · 2024-09-25T01:43:44Z

Deployed changes to https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

github-actions · 2024-09-25T01:44:32Z

PageSpeed Insights

Category	Score
Accessibility	95
Best practices	96
Performance	61
SEO	69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3151.azurewebsites.net

amankumarrr · 2024-09-25T01:49:46Z

@bradystroud
Fixed the issue for web vitals, as it was being called outside the AppInsight provider.

bradystroud

LGTM - Aman and I checked out the results in app insights

📈 Added app insights telemetry for app components

83ef4fe

Calinator444 changed the title ~~📈 Added app insights telemetry for app components~~ 📈 App Router - added app insights telemetry for app components Sep 23, 2024

Calinator444 added 2 commits September 23, 2024 14:53

🚨 Cleaned up linting errors

6479acd

Merge branch 'main' into fix-app-insights

1f81b73

removed fallback text from suspense boundary

7913bd9

Calinator444 added 2 commits September 23, 2024 17:11

🐛 Fixed screen rendering blank while query params resolve

482d195

♻️ Removed unnecessary suspense boundary

dbbf5ed

Calinator444 added 6 commits September 24, 2024 09:27

⚡ Removed unnecessary suspense boundary from app router layout component

4aa5ee7

⚡ Added telemetry provider to template.tsx

153a48e

🚨 Fixed useReportWebVitals being called conditionally

e247a28

🚨 Removed unused imports from layout.tsx

f7a8df9

Merge branch 'main' into fix-app-insights

293da9a

Added template to layout properly

6d5d040

Calinator444 marked this pull request as ready for review September 24, 2024 00:52

Calinator444 and others added 4 commits September 24, 2024 11:04

🐛 Fixed TelemetryProvider not receiving appInsights from context prov…

971478d

…ider

🚨 Removed unused import

2af610b

Adding web vitals as client component

02d3a0c

cleaning up redundant components

1b8055a

amankumarrr added 2 commits September 24, 2024 15:08

handling undefined for appInsight

08c0bab

Fixing rewards URL

1916471

removing console log

fdbd863

amankumarrr added 5 commits September 25, 2024 09:07

Adding ISR

072c1c6

Adding placeholder for the countdown

609c6ac

Removing unused MenuData variable

868b57d

Merge branch 'main' into fix-app-insights

d269981

removing unused import

6712157

amankumarrr requested review from wicksipedia and bradystroud September 25, 2024 00:05

Wrapping web vitals with AppInsight

e0e3e58

bradystroud approved these changes Sep 25, 2024

View reviewed changes

amankumarrr merged commit a03d292 into main Sep 25, 2024
11 checks passed

amankumarrr deleted the fix-app-insights branch September 25, 2024 01:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

📈 App Router - added app insights telemetry for app components #3151

📈 App Router - added app insights telemetry for app components #3151

Calinator444 commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

Calinator444 commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

amankumarrr commented Sep 23, 2024 •

edited

Loading

amankumarrr commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

amankumarrr commented Sep 24, 2024

amankumarrr commented Sep 24, 2024

amankumarrr commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

Calinator444 commented Sep 25, 2024

Calinator444 commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

amankumarrr commented Sep 25, 2024 •

edited

Loading

bradystroud left a comment •

edited

Loading

📈 App Router - added app insights telemetry for app components #3151

📈 App Router - added app insights telemetry for app components #3151

Conversation

Calinator444 commented Sep 23, 2024 • edited Loading

Description

github-actions bot commented Sep 23, 2024 • edited Loading

Coverage report

Test suite run success

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

PageSpeed Insights

Calinator444 commented Sep 23, 2024 • edited Loading

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 23, 2024

PageSpeed Insights

amankumarrr commented Sep 23, 2024 • edited Loading

amankumarrr commented Sep 23, 2024 • edited Loading

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

PageSpeed Insights

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

PageSpeed Insights

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

PageSpeed Insights

amankumarrr commented Sep 24, 2024

amankumarrr commented Sep 24, 2024

amankumarrr commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

PageSpeed Insights

Calinator444 commented Sep 25, 2024

Calinator444 commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

PageSpeed Insights

amankumarrr commented Sep 25, 2024 • edited Loading

bradystroud left a comment • edited Loading

Choose a reason for hiding this comment

Calinator444 commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

Calinator444 commented Sep 23, 2024 •

edited

Loading

amankumarrr commented Sep 23, 2024 •

edited

Loading

amankumarrr commented Sep 23, 2024 •

edited

Loading

amankumarrr commented Sep 25, 2024 •

edited

Loading

bradystroud left a comment •

edited

Loading